chore: port echo drift to lilac [BB-4704]#443
Merged
Agrendalath merged 12 commits intoopencraft-release/lilac.2-echofrom Nov 26, 2021
Merged
chore: port echo drift to lilac [BB-4704]#443Agrendalath merged 12 commits intoopencraft-release/lilac.2-echofrom
Agrendalath merged 12 commits intoopencraft-release/lilac.2-echofrom
Conversation
This fixes the removal of the new post indicator in the Discussion XBlock once a thread has been opened. (cherry picked from commit b62478c)
… input (openedx#25950) * prevent a backbone fieldview race condition that can delete user input eslint for effected * Fixing quality * Allow _super in fields.js * Fixing new issues * Revert some changes * Fixing errors, formatting * Fix bug * Fix eslint rule allowing _super * Refactor code Co-authored-by: Dylan Grafmyre <dylan@opencraft.com> Co-authored-by: Paulo Viadanna <paulo@opencraft.com> (cherry picked from commit 8995f1b)
On focus to the answer submition notification, the notification was scrolled to center of screen. This behaviour was on Chrome(87+) browser. This commits overrides the focus jQuery plugin to set the alignment of answer notifications to the bottom of the viewport. Fix the custom focus jQuery plugin Co-authored-by: Agrendalath (cherry picked from commit 52ab785)
…utton openedx#24020 introduced a workaround for viewing the current vertical in Studio However, replacing `window.location.href` on `click` did not support opening it in a new tab. (cherry picked from commit 01ada0b)
Importing a course with an invalid source library version (e.g. created on another instance) should not make the import fail. (cherry picked from commit 4b8421d)
…ation report There are two distinct ways to store a city for users in edx-platform: one directly in UserProfile.city, and another in UserProfile.meta. Depending on configuration, both fields can be used. Though the UserProfile.meta['city'] field is not set unless specifically configured, so we choose this over the UserProfile.city field when generating the student features report. Additional details and discussion available on edx/edx-platform#23171 (cherry picked from commit ddffeaa)
This: 1. Introduces a variable for the Course Outline view in Studio. A custom theme can override it to add new editors. 2. Exports a function for creating new editor modals. A custom theme can use it to create editors without adding boilerplate code. 3. Adds a pluggable override for XBlock fields that are passed to the Studio. Without this, custom editors in Studio cannot retrieve values of XBlock fields. (cherry picked from commit e633cc9)
) This is a follow-up to edx#1087, which reverted this change. According to the PR comments, parsing strings with XML comments inside them was causing errors. This does not seem to be the case anymore - these strings are just hidden when the block is rendered, but they are not breaking XBlocks. This also handles (ignores) the comments that could be added directly to the LibraryContentBlock in the XML export by users. (cherry picked from commit 4bf829d)
edx/edx-platform#24365 has changed the completion mode of these blocks. Before Koa, it was sufficient to view the block to get a completion checkmark. Since Koa, all children of the block must be completed. This adds a toggle to change the completion behavior back to the previous one so that the user experience can be consistent if needed.
This adds a reset option to a Randomized Content Block (LibraryContentBlock) to allow an OpenEdx user to reset questions in a Randomized Content Block. This is achieved by adding a `Reset Problems` button to the UI of a vertical with randomized content, and a reset handler to process the request.
Most tags that could contain solutions or hints were already being removed, but the regex did not include the case when they contained attributes.
Agrendalath
force-pushed
the
agrendalath/bb-4704-port_echo_drift_to_lilac
branch
from
9b96bb2 to
dcdcc25
Compare
shimulch
approved these changes
Nov 26, 2021
shimulch
left a comment
shimulch
left a comment
There was a problem hiding this comment.
@Agrendalath LGTM 👍
- I tested this: run on local lilac devstack. Performs some actions, visited some pages, didn't encounter anything broken.
- I read through the code - those are already reviewed commits.
- [N/A] I checked for accessibility issues
- Includes documentation
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This cherry-picks the following PRs: