Skip to content

fix(maple): apply language specified in Site Configuration [BB-6801]#509

Closed
Agrendalath wants to merge 1 commit intoopencraft-release/maple.3from
agrendalath/bb-6801-fix_site-specific_language_maple
Closed

fix(maple): apply language specified in Site Configuration [BB-6801]#509
Agrendalath wants to merge 1 commit intoopencraft-release/maple.3from
agrendalath/bb-6801-fix_site-specific_language_maple

Conversation

@Agrendalath
Copy link
Member

This backports #508 to Maple.

@Agrendalath Agrendalath self-assigned this Nov 23, 2022
Previously, this solution was implemented in the `dark_lang` middleware.
However, the `lang_pref` middleware started setting the user-preferred
language by default, which resulted in overriding the language cookie twice
for a single request (making this feature unusable). In this commit, the
language from Site Configuration will be applied after the one specified in
user preferences, to allow setting a language globally for a specific Site.
@Agrendalath Agrendalath force-pushed the agrendalath/bb-6801-fix_site-specific_language_maple branch from a8d3c0c to 07dc1f5 Compare November 24, 2022 09:20
@Agrendalath
Copy link
Member Author

We will not need this feature in Maple. Closing.

@Agrendalath Agrendalath closed this Dec 7, 2022
@Agrendalath Agrendalath deleted the agrendalath/bb-6801-fix_site-specific_language_maple branch December 7, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments