fix(nutmeg): apply language specified in Site Configuration [BB-6801]#508
Closed
Agrendalath wants to merge 1 commit intoopencraft-release/nutmeg.2from
Closed
fix(nutmeg): apply language specified in Site Configuration [BB-6801]#508Agrendalath wants to merge 1 commit intoopencraft-release/nutmeg.2from
Agrendalath wants to merge 1 commit intoopencraft-release/nutmeg.2from
Conversation
Previously, this solution was implemented in the `dark_lang` middleware. However, the `lang_pref` middleware started setting the user-preferred language by default, which resulted in overriding the language cookie twice for a single request (making this feature unusable). In this commit, the language from Site Configuration will be applied after the one specified in user preferences, to allow setting a language globally for a specific Site.
Agrendalath
force-pushed
the
agrendalath/bb-6801-fix_site-specific_language
branch
from
38f0ca1 to
921f2d4
Compare
Member
Author
|
Closing, as we used a different approach in #516. |
Agrendalath
deleted the
agrendalath/bb-6801-fix_site-specific_language
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, this solution was implemented in the
dark_langmiddleware. However, thelang_prefmiddleware started setting the user-preferred language by default, which resulted in overriding the language cookie twice for a single request (making this feature unusable). In this commit, the language from Site Configuration will be applied after the one specified in user preferences, to allow setting a language globally for a specific Site.