fix: use language specified in SiteConfiguration [BB-6930]#516
Merged
Agrendalath merged 2 commits intoopencraft-release/nutmeg.2from Dec 9, 2022
Merged
Conversation
This feature was implemented in b01544d to replace the session's language in the request. 44ddbdf moved the process from the request to the response, which made this feature unusable (because the request was already processed). 44ddbdf also made this feature set the language cookie. However, it is overwritten by user preferences. To fix this, we could overwrite the cookie of the response after it's set from user preferences. However, it is not an ideal solution because when users switch between Sites with different languages, the first response will use the language of the previous page. Therefore, this ignores user preferences and alters the cookie of a request instead.
This test stopped throwing the `TransactionManagementError` once we added the `site_configuration.get_value()` call to the language preferences middleware.
Agrendalath
force-pushed
the
agrendalath/bb-6930-fix_site_language_nutmeg
branch
from
e361442 to
a3f869a
Compare
pkulkark
approved these changes
Dec 9, 2022
Member
pkulkark
left a comment
pkulkark
left a comment
There was a problem hiding this comment.
LGTM 👍
- I tested this: Tested the upstream PR and ensured the changes are same.
- I read through the code
-
I checked for accessibility issuesN/A -
Includes documentationN/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This backports openedx#31408 to the common Nutmeg branch.