Sync opencraft-release/palm.1 with Upstream 20230717-1689605830#555
Merged
Agrendalath merged 2 commits intoopencraft-release/palm.1from Jul 17, 2023
Merged
Conversation
…2380) (openedx#32506) * perf!: add support for caching programs on per site bases
Agrendalath
force-pushed
the
sync-open-release/palm.master-20230717-1689605830
branch
from
9141a63 to
42e84e3
Compare
Agrendalath
approved these changes
Jul 17, 2023
Member
Agrendalath
left a comment
Agrendalath
left a comment
There was a problem hiding this comment.
👍
- I tested this: checked that the diff matches the upstream commits
- I read through the code
- I checked for accessibility issues: n/a
- Includes documentation: n/a
- I made sure any change in configuration variables is reflected in the corresponding client's
configuration-securerepository: n/a
Regarding the failing commitlint action - the enhancement: prefix is invalid. It was added while squashing and merging the PR to the upstream platform, so the commitlint action could not catch it there.
Agrendalath
deleted the
sync-open-release/palm.master-20230717-1689605830
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing opencraft-release/palm.1 with Upstream
Note on Conflicts⚠️
In cases of conflicts you can go ahead and resolve it here on Github if it is simple enough. However if it is a more complicated conflict please follow the steps below:
sync-open-release/palm.master-20230717-1689605830locally:opencraft-release/palm.1into that branch, make sure your[REMOTE]is pointing toopencraft-release/palm.1:sync-open-release/palm.master-20230717-1689605830to update this PRNote: Please use the "Create a merge commit" option as it avoids issues when checking diffs with upstream.