-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Add Hook Dependency Injection extension method with Hook instance #513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
askpt
merged 4 commits into
open-feature:main
from
kylejuliandev:feat/add-additional-hook-extension-methods
Jul 14, 2025
Merged
feat: Add Hook Dependency Injection extension method with Hook instance #513
askpt
merged 4 commits into
open-feature:main
from
kylejuliandev:feat/add-additional-hook-extension-methods
Jul 14, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 87.35% 87.39% +0.04%
==========================================
Files 47 47
Lines 1827 1833 +6
Branches 190 190
==========================================
+ Hits 1596 1602 +6
Misses 188 188
Partials 43 43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
askpt
approved these changes
Jul 7, 2025
askpt
approved these changes
Jul 12, 2025
arttonoyan
requested changes
Jul 12, 2025
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
beeme1mr
approved these changes
Jul 14, 2025
arttonoyan
approved these changes
Jul 14, 2025
This was referenced Jul 31, 2025
Closed
This was referenced Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
In #512 I needed to tweak the sample AspNetCore application to pass Hook options to the MetricsHook. I noticed that in order to pass the options I needed to use the delegate based approach, while discarding the
serviceProvider, like:It would be simpler and easier for devs to interact with a third overload that allows them to pass an instance of the hook that they want to interact with, like so:
Related Issues
Notes
Follow-up Tasks
How to test