chore: bump Go to version 1.20 #255

odubajDT · 2024-02-13T14:11:55Z

Fixes #253

codecov · 2024-02-13T14:13:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.42%. Comparing base (b624a43) to head (7e5c426).
Report is 2 commits behind head on main.

❗ Current head 7e5c426 differs from pull request most recent head 65db40b. Consider uploading reports for the commit 65db40b to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          10       10           
  Lines        1163     1163           
=======================================
  Hits          947      947           
  Misses        196      196           
  Partials       20       20

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Kavindu-Dodan · 2024-02-13T16:47:48Z

My concern here is the version jump from 1.19 to 1.21. Given SDK is a central piece of OF, I think we should move step-wise (1.19 -> 1.20 -> 1.21) so that adaptation becomes easier where needed. We have a tracking issue for 1.20 already - #253

Kavindu-Dodan · 2024-02-23T21:10:13Z

I have upgraded the PR to bump Go version to 1.20. This allows us to upgrade SDK's go version linearly, avoiding unnecessary impact on downstream users.

Kavindu-Dodan

Pending for TC decision on runtime support & documentation

See discussion - https://github.com/orgs/open-feature/discussions/356

toddbaert · 2024-04-09T17:15:05Z

After our meeting I'm sure I can say the TC will not block dropping Go 1.19, as long as the go-maintainers support that.

Go is a particularly fast-moving runtime.

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

beeme1mr · 2024-04-09T17:44:07Z

Can we extend the readme to include a section on our support policy?

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>

Kavindu-Dodan · 2024-04-09T19:43:29Z

Can we extend the readme to include a section on our support policy?

I tried to add this with this commit - f854ec4

README.md

Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>

* chore: bump Go to version 1.21 Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> * update readme with go version and note Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> * Update README.md Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>

* added support for domains Signed-off-by: gunishmatta <gunishmatta@gmail.com> * added support for domains Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore(deps): update actions/setup-go action to v5 (#237) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore(deps): update cyclonedx/gh-gomod-generate-sbom action to v2 (#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * Update openfeature/client.go Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Gunish Matta <33680363+gunishmatta@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * Update openfeature/client.go Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Gunish Matta <33680363+gunishmatta@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * feat: Added domain scoping #261 Please enter the commit message for your chanes. Lines starting Author: Gunish Matta <gunishmatta@gmail.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore(main): release 1.11.0 (#254) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore: bump Go to version 1.20 (#255) * chore: bump Go to version 1.21 Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> * update readme with go version and note Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> * Update README.md Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> * fix(deps): update module github.com/cucumber/godog to v0.14.1 (#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore(deps): update goreleaser/goreleaser-action action to v5 (#219) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore(deps): update codecov/codecov-action action to v4 (#250) * chore(deps): update codecov/codecov-action action to v4 * add codecov upload token Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> --------- Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * fix(deps): update module golang.org/x/exp to v0.0.0-20240416160154-fe59bbe5cc7f (#269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * chore(deps): update codecov/codecov-action action to v4.3.1 (#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com> * Revert "code review changes" This reverts commit 3472ee8. Signed-off-by: gunishmatta <gunishmatta@gmail.com> * code review changes Signed-off-by: gunishmatta <gunishmatta@gmail.com> --------- Signed-off-by: gunishmatta <gunishmatta@gmail.com> Signed-off-by: Gunish Matta <33680363+gunishmatta@users.noreply.github.com> Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: Dave Henderson <dhenderson@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: odubajDT <93584209+odubajDT@users.noreply.github.com> Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>

odubajDT marked this pull request as ready for review February 13, 2024 14:42

odubajDT requested a review from a team as a code owner February 13, 2024 14:42

odubajDT marked this pull request as draft February 13, 2024 14:56

odubajDT marked this pull request as ready for review February 13, 2024 15:27

Kavindu-Dodan force-pushed the chore/bump-go branch from a7dec38 to 7e5c426 Compare February 23, 2024 21:08

Kavindu-Dodan approved these changes Feb 23, 2024

View reviewed changes

Kavindu-Dodan requested review from beeme1mr and toddbaert February 23, 2024 21:09

Kavindu-Dodan changed the title ~~chore: bump Go to version 1.21~~ chore: bump Go to version 1.20 Feb 28, 2024

This was referenced Mar 25, 2024

[FEATURE] Move to log/slog logging #260

Closed

fix(deps): update golang.org/x/exp digest to a685a6e #209

Closed

Kavindu-Dodan requested changes Mar 28, 2024

View reviewed changes

Kavindu-Dodan mentioned this pull request Apr 9, 2024

chore(main): release 1.11.0 #254

Merged

toddbaert approved these changes Apr 9, 2024

View reviewed changes

Kavindu-Dodan self-requested a review April 9, 2024 17:19

chore: bump Go to version 1.21

16aec69

Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com>

Kavindu-Dodan force-pushed the chore/bump-go branch from 7e5c426 to 16aec69 Compare April 9, 2024 17:19

Kavindu-Dodan approved these changes Apr 9, 2024

View reviewed changes

Kavindu-Dodan requested review from thomaspoignant and lukas-reining April 9, 2024 17:20

lukas-reining approved these changes Apr 9, 2024

View reviewed changes

update readme with go version and note

f854ec4

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>

beeme1mr reviewed Apr 9, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

65db40b

Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com>

Kavindu-Dodan requested a review from beeme1mr April 9, 2024 20:08

beeme1mr approved these changes Apr 9, 2024

View reviewed changes

Kavindu-Dodan merged commit fbec799 into open-feature:main Apr 9, 2024
4 checks passed

github-actions bot mentioned this pull request Apr 9, 2024

chore(main): release 1.12.0 #265

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump Go to version 1.20 #255

chore: bump Go to version 1.20 #255

odubajDT commented Feb 13, 2024 •

edited by Kavindu-Dodan

Loading

codecov bot commented Feb 13, 2024 •

edited

Loading

Kavindu-Dodan commented Feb 13, 2024

Kavindu-Dodan commented Feb 23, 2024

Kavindu-Dodan left a comment •

edited

Loading

toddbaert commented Apr 9, 2024

beeme1mr commented Apr 9, 2024

Kavindu-Dodan commented Apr 9, 2024

chore: bump Go to version 1.20 #255

chore: bump Go to version 1.20 #255

Conversation

odubajDT commented Feb 13, 2024 • edited by Kavindu-Dodan Loading

codecov bot commented Feb 13, 2024 • edited Loading

Codecov Report

Kavindu-Dodan commented Feb 13, 2024

Kavindu-Dodan commented Feb 23, 2024

Kavindu-Dodan left a comment • edited Loading

Choose a reason for hiding this comment

toddbaert commented Apr 9, 2024

beeme1mr commented Apr 9, 2024

Kavindu-Dodan commented Apr 9, 2024

odubajDT commented Feb 13, 2024 •

edited by Kavindu-Dodan

Loading

codecov bot commented Feb 13, 2024 •

edited

Loading

Kavindu-Dodan left a comment •

edited

Loading