feat: Implement domain scoping #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunishmatta
changed the title
beeme1mr
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Hey @gunishmatta, thanks for the PR. I left some feedback regarding changes made to the provider name. It's a bit confusing but the provider name is still valid. It's only the client name that has changed to domain.
Please also update the readme to mention domains. You can see an example on the JS SDK.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #261 +/- ##
==========================================
- Coverage 81.91% 81.74% -0.17%
==========================================
Files 10 10
Lines 962 964 +2
==========================================
Hits 788 788
- Misses 154 156 +2
Partials 20 20 ☔ View full report in Codecov by Sentry. |
|
Hi Team @beeme1mr @Kavindu-Dodan Thanks for your valuable feedback, Please give me a couple of days, I am out for a vacation, I will update the PR as soon as I get time. |
|
@gunishmatta really nice work 🙌 could you please check the minor changes I proposed? They should be easy to complete and once done I think this is ready |
gunishmatta
pushed a commit
to gunishmatta/go-sdk
that referenced
this pull request
May 4, 2024
Please enter the commit message for your chanes. Lines starting Author: Gunish Matta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
…en-feature#179) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Gunish Matta <33680363+gunishmatta@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Gunish Matta <33680363+gunishmatta@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Please enter the commit message for your chanes. Lines starting Author: Gunish Matta <gunishmatta@gmail.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
* chore: bump Go to version 1.21 Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> * update readme with go version and note Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> * Update README.md Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> --------- Signed-off-by: odubajDT <ondrej.dubaj@dynatrace.com> Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Signed-off-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com> Co-authored-by: Kavindu Dodanduwa <Kavindu-Dodan@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
…eature#267) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
…eature#219) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
…#250) * chore(deps): update codecov/codecov-action action to v4 * add codecov upload token Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> --------- Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
…59bbe5cc7f (open-feature#269) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
…ture#270) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: gunishmatta <gunishmatta@gmail.com>
This reverts commit 3472ee8. Signed-off-by: gunishmatta <gunishmatta@gmail.com>
Signed-off-by: gunishmatta <gunishmatta@gmail.com>
|
Hi @Kavindu-Dodan / @beeme1mr I am done with the changes, please merge if looks good. |
Kavindu-Dodan
approved these changes
May 8, 2024
|
I'll review this tomorrow. Thanks! |
toddbaert
approved these changes
May 16, 2024
There was a problem hiding this comment.
Sorry for the delay @gunishmatta . Thanks a lot for the changes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #257
Notes
Follow-up Tasks
How to test