Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added an automatic module name (#362) #363

Merged

Conversation

ARobertsCollibra
Copy link
Member

This PR

  • Adds an automatic module name that is more descriptive than sdk. The new module name is dev.openfeature.sdk.

Related Issues

Fixes #362

Notes

This is the easy fix, modularizing the entire Jar would take longer. There might be a better way to achieve this but I am not a maven expert.

How to test

After the change the produced Jar should have Automatic-Module-Name: dev.openfeature.sdk in the META-INF/MANIFEST.MF file.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration .github/workflows/pullrequest.yml:build. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #363 (2ef2acb) into main (996cbd8) will not change coverage.
The diff coverage is n/a.

❗ Current head 2ef2acb differs from pull request most recent head 66a2eaf. Consider uploading reports for the commit 66a2eaf to get more accurate results

@@            Coverage Diff            @@
##               main     #363   +/-   ##
=========================================
  Coverage     91.53%   91.53%           
  Complexity      213      213           
=========================================
  Files            23       23           
  Lines           496      496           
  Branches         32       32           
=========================================
  Hits            454      454           
  Misses           24       24           
  Partials         18       18           
Flag Coverage Δ
unittests 91.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

pom.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Kavindu-Dodan Kavindu-Dodan merged commit cfd7086 into open-feature:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The SDK Jar does not provide a Module Name
4 participants