-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: added an automatic module name (#362) #363
fix: added an automatic module name (#362) #363
Conversation
bb5bc0b
to
2ef2acb
Compare
You have successfully added a new CodeQL configuration |
Signed-off-by: Adam Roberts <adam.roberts@collibra.com>
2ef2acb
to
3c7e6cf
Compare
Codecov Report
@@ Coverage Diff @@
## main #363 +/- ##
=========================================
Coverage 91.53% 91.53%
Complexity 213 213
=========================================
Files 23 23
Lines 496 496
Branches 32 32
=========================================
Hits 454 454
Misses 24 24
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
This PR
sdk
. The new module name isdev.openfeature.sdk
.Related Issues
Fixes #362
Notes
This is the easy fix, modularizing the entire Jar would take longer. There might be a better way to achieve this but I am not a maven expert.
How to test
After the change the produced Jar should have
Automatic-Module-Name: dev.openfeature.sdk
in theMETA-INF/MANIFEST.MF
file.