Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-memory provider for e2e testing and minimal SDK usage #523

Closed
2 tasks done
Kavindu-Dodan opened this issue Jul 21, 2023 · 3 comments
Closed
2 tasks done

In-memory provider for e2e testing and minimal SDK usage #523

Kavindu-Dodan opened this issue Jul 21, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Kavindu-Dodan
Copy link
Contributor

Kavindu-Dodan commented Jul 21, 2023 •
edited
Loading

As proposed by OFEP: SDK end-to-end test strategy 1, we should create an in-memory provider for Java-sdk

We already have contributions for Python2 & Go 3, and we can use same flag format, constructors & error handling strategy for this implementation.

  • Implement the in-memory provider
  • Migrate existing e2e tests4 to newly create in-memory provider
    • search repo for https://github.com/open-feature/java-sdk/issues/523 for related TODOs.

Footnotes

  1. https://github.com/open-feature/ofep/pull/71 ↩

  2. https://github.com/open-feature/python-sdk/pull/157 ↩

  3. https://github.com/open-feature/go-sdk/pull/192 ↩

  4. https://github.com/open-feature/java-sdk/tree/main/src/test/java/dev/openfeature/sdk/e2e ↩
@Kavindu-Dodan Kavindu-Dodan added the enhancement New feature or request label Jul 21, 2023
@Kavindu-Dodan Kavindu-Dodan changed the title In-memory provider for testing and minimal usage In-memory provider for e2e testing and minimal SDK usage Jul 21, 2023
@toddbaert toddbaert mentioned this issue Aug 2, 2023
Merged
@toddbaert
Copy link
Member

Small related PR here: #543

@liran2000 liran2000 mentioned this issue Aug 7, 2023
Merged
@Kavindu-Dodan Kavindu-Dodan mentioned this issue Aug 10, 2023
Closed
@liran2000
Copy link
Member

@Kavindu-Dodan @toddbaert as PR merged, can be resolved ?

@Kavindu-Dodan
Copy link
Contributor Author

@liran2000 yes, this is complete. Thank you for working on this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Kavindu-Dodan @toddbaert @liran2000