feat: implement InMemoryProvider #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobond
force-pushed
the
feat/in-memory-provider
branch
from
20ff833
to
68da7f4
Compare
federicobond
commented
Jul 18, 2023
federicobond
force-pushed
the
feat/in-memory-provider
branch
2 times, most recently
from
0ba7ae0
to
bae09dc
Compare
Codecov Report
@@ Coverage Diff @@
## main #157 +/- ##
==========================================
+ Coverage 93.26% 93.83% +0.57%
==========================================
Files 22 23 +1
Lines 386 438 +52
==========================================
+ Hits 360 411 +51
- Misses 26 27 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
feat/in-memory-provider
branch
from
bae09dc
to
4d1b078
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
federicobond
force-pushed
the
feat/in-memory-provider
branch
from
a36579b
to
77f43f9
Compare
Signed-off-by: Federico Bond <federicobond@gmail.com>
beeme1mr
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Implements an in-memory provider that roughly follows @Kavindu-Dodan proposal in open-feature/ofep#71
Notes
A slightly different set of tradeoffs were made regarding the design of the InMemoryFlag object, which should be reviewed carefully. In particular, the State field in the Go implementation was replaced by an explicit Reason which seemed more ergonomic.