feat: defaults to NoOpProvider #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensures a provider will always be returned Signed-off-by: Tom Carrio <tom@carrio.dev>
Signed-off-by: Tom Carrio <tom@carrio.dev>
|
Updated tests 👍 |
Codecov Report
@@ Coverage Diff @@
## main #66 +/- ##
==========================================
- Coverage 92.69% 92.66% -0.03%
==========================================
Files 19 19
Lines 342 341 -1
==========================================
- Hits 317 316 -1
Misses 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
The |
beeme1mr
reviewed
Dec 27, 2022
beeme1mr
approved these changes
Dec 27, 2022
Co-authored-by: Michael Beemer <beeme1mr@users.noreply.github.com> Signed-off-by: Tom Carrio <tom@carrio.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1234523
Notes
This fixes an issue with spec compliance
Follow-up Tasks
- TestsHow to test
Given you have not set a provider
When you retrieve an OpenFeature client
Then an error will not be raised