Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: defaults to NoOpProvider #66

Merged
merged 3 commits into from
Dec 28, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions open_feature/open_feature_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,15 @@

from open_feature.exception.exceptions import GeneralError
from open_feature.open_feature_client import OpenFeatureClient
from open_feature.provider.no_op_provider import NoOpProvider
from open_feature.provider.provider import AbstractProvider

_provider: typing.Optional[AbstractProvider] = None
_provider: AbstractProvider = NoOpProvider()


def get_client(
name: typing.Optional[str] = None, version: typing.Optional[str] = None
) -> OpenFeatureClient:
if _provider is None:
raise GeneralError(
error_message="Provider not set. Call set_provider before using get_client"
)
return OpenFeatureClient(name=name, version=version, provider=_provider)


Expand Down
16 changes: 7 additions & 9 deletions tests/test_open_feature_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,18 +6,16 @@
from open_feature.provider.no_op_provider import NoOpProvider


def test_should_raise_exception_with_nop_client():
def test_should_not_raise_exception_with_noop_client():
# Given
# No provider has been set
# When
with pytest.raises(GeneralError) as ge:
get_client()
client = get_client(name="Default Provider", version="1.0")

# Then
assert ge.value
assert (
ge.value.error_message
== "Provider not set. Call set_provider before using get_client"
)
assert ge.value.error_code == ErrorCode.GENERAL
assert client.name == "Default Provider"
assert client.version == "1.0"
assert isinstance(client.provider, NoOpProvider)


def test_should_return_open_feature_client_when_configured_correctly():
Expand Down