Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations to remove in 3.0 #3283

Closed
23 tasks done
sergei-maertens opened this issue Jul 21, 2023 · 5 comments · Fixed by #4872 or #4941
Closed
23 tasks done

Deprecations to remove in 3.0 #3283

sergei-maertens opened this issue Jul 21, 2023 · 5 comments · Fixed by #4872 or #4941
Assignees
Labels
epic Large theme and/or meta issue
Milestone

Comments

@sergei-maertens
Copy link
Member

sergei-maertens commented Jul 21, 2023

A list of breaking changes to make when we get to version 3.0

CTRL + F on DeprecationWarning in the backend to find more.

@SilviaAmAm
Copy link
Contributor

There is also the "old" cosign, but I don't know if we want to remove it afterall

@sergei-maertens
Copy link
Member Author

There is also the "old" cosign, but I don't know if we want to remove it afterall

Good shout - we can discuss that at some point. I think it depends a bit on who's actually using it?

@sergei-maertens
Copy link
Member Author

@vaszig you can pick up removing the old appointments integration

sergei-maertens added a commit that referenced this issue Nov 15, 2024
Per the deprecation warning we drop support for exports containing
the legacy translation store.
sergei-maertens added a commit that referenced this issue Nov 15, 2024
Per the deprecation warning we drop support for exports containing
the legacy translation store.
stevenbal added a commit that referenced this issue Nov 18, 2024
@stevenbal
Copy link
Contributor

Objects API/ZGW groups shouldn't have fields nullable

@sergei-maertens the only field that is nullable from what I can see is objects_api_group in ZGW registration options: https://github.com/open-formulieren/open-forms/blob/master/src/openforms/registrations/contrib/zgw_apis/options.py#L114

Should this be required?

sergei-maertens added a commit that referenced this issue Nov 18, 2024
Per the deprecation warning we drop support for exports containing
the legacy translation store.
stevenbal added a commit that referenced this issue Nov 18, 2024
stevenbal added a commit that referenced this issue Nov 18, 2024
sergei-maertens added a commit that referenced this issue Nov 20, 2024
This component never made sense, it was only added reluctantly because
the original programme of requirements specified it.

Passwords being stored in plain text are a terrible, terrible idea.
Nobody should have every actually used this in a real form.
sergei-maertens added a commit that referenced this issue Nov 21, 2024
This component never made sense, it was only added reluctantly because
the original programme of requirements specified it.

Passwords being stored in plain text are a terrible, terrible idea.
Nobody should have every actually used this in a real form.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
The shape of data that we store was badly documented, not in the least
because we barely had any idea what kind of information we receive.

Since Open Forms 2.7.0 it has been fleshed out what the mandata context
looks like, and properly implemented backed by a proposal for a
standard which is implemented all the way to Open Zaak to try out.

This legacy context is now being removed in favour of the new way
to track and expose the mandata context.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
With Open Forms 3.0, we can make the breaking change of updating the
default.

The new OIDC API endpoints all point to a single callback URL, so it
means less configuration overhead on the identity provider side. The
breaking change means that the new URI's must be added to the
allowlist of the identity provider.

The new endpoint is '/auth/oidc/callback/', and it applies to all
OIDC configuration flavours.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
With Open Forms 3.0, we can make the breaking change of updating the
default.

The new OIDC API endpoints all point to a single callback URL, so it
means less configuration overhead on the identity provider side. The
breaking change means that the new URI's must be added to the
allowlist of the identity provider.

The new endpoint is '/auth/oidc/callback/', and it applies to all
OIDC configuration flavours.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Providing both the used_in and is_reusable filter parameters no longer
returns records that match either condition, instead it applies the
default AND behaviour.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Some older endpoints used underscores, but the majority of endpoints
use kebab-case to separate words, so now everything is normalized.

This requires a PR to the SDK to handle the changes, as no redirects
are being set up. All of these endpoints are private API.
sergei-maertens added a commit to open-formulieren/open-forms-sdk that referenced this issue Dec 12, 2024
…casing in the API endpoints

Switched from underscore to kebab case, so hardcoded endpoints need to
be adapted.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Catalogi and Documents API are optional, but the objecttypes and objects
API services are not. These fields were null because the model was
originally a django-solo singleton model which must be able to be
created without any services existing prior.

A check script is added to prevent being stuck in half-migrated
upgrades.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Left-overs from a django-solo model too (see previous commit), these
fields really cannot be empty to do anything useful.

This properly sets up the required constraints at the database level
and removes confusion in the application code.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Catalogi and Documents API are optional, but the objecttypes and objects
API services are not. These fields were null because the model was
originally a django-solo singleton model which must be able to be
created without any services existing prior.

A check script is added to prevent being stuck in half-migrated
upgrades.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Left-overs from a django-solo model too (see previous commit), these
fields really cannot be empty to do anything useful.

This properly sets up the required constraints at the database level
and removes confusion in the application code.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Catalogi and Documents API are optional, but the objecttypes and objects
API services are not. These fields were null because the model was
originally a django-solo singleton model which must be able to be
created without any services existing prior.

A check script is added to prevent being stuck in half-migrated
upgrades.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Left-overs from a django-solo model too (see previous commit), these
fields really cannot be empty to do anything useful.

This properly sets up the required constraints at the database level
and removes confusion in the application code.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Catalogi and Documents API are optional, but the objecttypes and objects
API services are not. These fields were null because the model was
originally a django-solo singleton model which must be able to be
created without any services existing prior.

A check script is added to prevent being stuck in half-migrated
upgrades.
sergei-maertens added a commit that referenced this issue Dec 12, 2024
Left-overs from a django-solo model too (see previous commit), these
fields really cannot be empty to do anything useful.

This properly sets up the required constraints at the database level
and removes confusion in the application code.
@sergei-maertens sergei-maertens moved this from In Progress to Implemented in Development Dec 13, 2024
sergei-maertens added a commit that referenced this issue Dec 17, 2024
With Open Forms 3.0, we can make the breaking change of updating the
default.

The new OIDC API endpoints all point to a single callback URL, so it
means less configuration overhead on the identity provider side. The
breaking change means that the new URI's must be added to the
allowlist of the identity provider.

The new endpoint is '/auth/oidc/callback/', and it applies to all
OIDC configuration flavours.
sergei-maertens added a commit that referenced this issue Dec 18, 2024
…gration-procedure

📝 [#3283] Document registration backend migration procedure
@github-project-automation github-project-automation bot moved this from Implemented to Done in Development Dec 18, 2024
sergei-maertens added a commit that referenced this issue Dec 19, 2024
With Open Forms 3.0, we can make the breaking change of updating the
default.

The new OIDC API endpoints all point to a single callback URL, so it
means less configuration overhead on the identity provider side. The
breaking change means that the new URI's must be added to the
allowlist of the identity provider.

The new endpoint is '/auth/oidc/callback/', and it applies to all
OIDC configuration flavours.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment