Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove password Formio component #4842

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

sergei-maertens
Copy link
Member

Part of #3283

This component never made sense, it was only added reluctantly because the original programme of requirements specified it.

Passwords being stored in plain text are a terrible, terrible idea. Nobody should have every actually used this in a real form.

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled
  • Release management

    • I have labelled the PR as "needs-backport" accordingly
  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh
  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@sergei-maertens sergei-maertens mentioned this pull request Nov 18, 2024
23 tasks
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.58%. Comparing base (e4fb7bb) to head (1e1cb1a).
Report is 25 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4842      +/-   ##
==========================================
- Coverage   96.58%   96.58%   -0.01%     
==========================================
  Files         749      749              
  Lines       25531    25519      -12     
  Branches     3376     3375       -1     
==========================================
- Hits        24659    24647      -12     
  Misses        608      608              
  Partials      264      264              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

This component never made sense, it was only added reluctantly because
the original programme of requirements specified it.

Passwords being stored in plain text are a terrible, terrible idea.
Nobody should have every actually used this in a real form.
@sergei-maertens sergei-maertens force-pushed the cleanup/3283-remove-password-component branch from 332796c to 1e1cb1a Compare November 21, 2024 17:02
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the existing Password components?Could we have a problem (I cannot think of something but just to make sure)?

@sergei-maertens
Copy link
Member Author

What about the existing Password components?Could we have a problem (I cannot think of something but just to make sure)?

Formio will render "Unknown component type 'password'" or something along those lines. But we've never actually seen anyone use this component (which restores my faith in humanity a little)

@sergei-maertens sergei-maertens merged commit 577b0df into master Nov 25, 2024
34 checks passed
@sergei-maertens sergei-maertens deleted the cleanup/3283-remove-password-component branch November 25, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants