Minor: Fix Postgres Cypress Failure (#14698)

open-metadata · Jan 13, 2024 · 21a701f · 21a701f
1 parent 3265d2a
commit 21a701f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/ingestion/src/metadata/ingestion/source/database/postgres/metadata.py b/ingestion/src/metadata/ingestion/source/database/postgres/metadata.py
@@ -203,9 +203,7 @@ def get_table_partition_details(
         self, table_name: str, schema_name: str, inspector
     ) -> Tuple[bool, TablePartition]:
         result = self.engine.execute(
-            POSTGRES_PARTITION_DETAILS.format(
-                table_name=table_name, schema_name=schema_name
-            )
+            POSTGRES_PARTITION_DETAILS, table_name=table_name, schema_name=schema_name
         ).all()
         if result:
             partition_details = TablePartition(

diff --git a/ingestion/src/metadata/ingestion/source/database/postgres/queries.py b/ingestion/src/metadata/ingestion/source/database/postgres/queries.py
@@ -71,7 +71,7 @@
         col.table_schema = par.relnamespace::regnamespace::text
         and col.table_name = par.relname
         and ordinal_position = pt.column_index
-     where par.relname='{table_name}' and  par.relnamespace::regnamespace::text='{schema_name}'
+     where par.relname=%(table_name)s and  par.relnamespace::regnamespace::text=%(schema_name)s
     """
 )
 

diff --git a/openmetadata-ui/src/main/resources/ui/cypress/e2e/Service/postgres.spec.js b/openmetadata-ui/src/main/resources/ui/cypress/e2e/Service/postgres.spec.js
@@ -37,14 +37,14 @@ const clearQuery = 'select pg_stat_statements_reset()';
 const selectQuery =
   'SELECT * FROM sales.order_items oi INNER JOIN sales.orders o ON oi.order_id=o.order_id';
 
-// @ayush - Need to fix postgres ingestion issue
-describe.skip('Postgres Ingestion', () => {
+describe('Postgres Ingestion', () => {
   beforeEach(() => {
     cy.login();
   });
 
   it('Trigger select query', () => {
     cy.postgreSQL(clearQuery);
+    cy.wait(500);
     cy.postgreSQL(selectQuery);
   });
 
@@ -132,7 +132,7 @@ describe.skip('Postgres Ingestion', () => {
 
     cy.get('#root\\/filterCondition')
       .scrollIntoView()
-      .type(`s.query like '%%${tableName}%%'`);
+      .type(`lower(s.query) like '%%${tableName}%%'`);
     cy.get('[data-testid="submit-btn"]')
       .scrollIntoView()
       .should('be.visible')