Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Fix Postgres Cypress Failure #14698

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Minor: Fix Postgres Cypress Failure #14698

merged 3 commits into from
Jan 13, 2024

Conversation

ulixius9
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added UI UI specific issues Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 12, 2024
@ulixius9 ulixius9 added the e2e This will trigger e2e test workflows label Jan 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.56% (26593/50600) 34.49% (10463/30339) 33.51% (3100/9251)

@cypress Cypress
Copy link

cypress bot commented Jan 12, 2024 •
edited
Loading

18 failed tests on run #32946 ↗︎

18 576 39 52 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

unskip postgres cypress
Project: openmetadata Commit: c021b7c6d0
Status: Failed Duration: 53:13 💡
Started: Jan 12, 2024 4:57 PM Ended: Jan 12, 2024 6:50 PM

Review all test suite changes for PR #14698 ↗︎

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ulixius9 ulixius9 merged commit 21a701f into main Jan 13, 2024
24 of 26 checks passed
@ulixius9 ulixius9 deleted the postgres_cypress_fix branch January 13, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees
No one assigned
Labels
e2e This will trigger e2e test workflows Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ulixius9 @chirag-madlani