Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Fix Postgres Cypress Failure #14698

Merged
merged 3 commits into from
Jan 13, 2024
Merged

Minor: Fix Postgres Cypress Failure #14698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f20a4e
Minor: Fix Postgres Cypress Failure
ulixius9 Jan 12, 2024
b9f9dec
Merge branch 'main' into postgres_cypress_fix
ulixius9 Jan 12, 2024
c021b7c
unskip postgres cypress
chirag-madlani Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ingestion/src/metadata/ingestion/source/database/postgres/metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,7 @@ def get_table_partition_details(
self, table_name: str, schema_name: str, inspector
) -> Tuple[bool, TablePartition]:
result = self.engine.execute(
POSTGRES_PARTITION_DETAILS.format(
table_name=table_name, schema_name=schema_name
)
POSTGRES_PARTITION_DETAILS, table_name=table_name, schema_name=schema_name
).all()
if result:
partition_details = TablePartition(
Expand Down
2 changes: 1 addition & 1 deletion ingestion/src/metadata/ingestion/source/database/postgres/queries.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
col.table_schema = par.relnamespace::regnamespace::text
and col.table_name = par.relname
and ordinal_position = pt.column_index
where par.relname='{table_name}' and par.relnamespace::regnamespace::text='{schema_name}'
where par.relname=%(table_name)s and par.relnamespace::regnamespace::text=%(schema_name)s
"""
)

Expand Down
6 changes: 3 additions & 3 deletions openmetadata-ui/src/main/resources/ui/cypress/e2e/Service/postgres.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ const clearQuery = 'select pg_stat_statements_reset()';
const selectQuery =
'SELECT * FROM sales.order_items oi INNER JOIN sales.orders o ON oi.order_id=o.order_id';

// @ayush - Need to fix postgres ingestion issue
describe.skip('Postgres Ingestion', () => {
describe('Postgres Ingestion', () => {
beforeEach(() => {
cy.login();
});

it('Trigger select query', () => {
cy.postgreSQL(clearQuery);
cy.wait(500);
cy.postgreSQL(selectQuery);
});

Expand Down Expand Up @@ -132,7 +132,7 @@ describe.skip('Postgres Ingestion', () => {

cy.get('#root\\/filterCondition')
.scrollIntoView()
.type(`s.query like '%%${tableName}%%'`);
.type(`lower(s.query) like '%%${tableName}%%'`);
cy.get('[data-testid="submit-btn"]')
.scrollIntoView()
.should('be.visible')
Expand Down
Loading