fix sso logo breaking due to antd icons component (#15083)

* fix sso logo breaking due to antd icons component * fix sonar issue * fix deploy ingestion icon --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
open-metadata · Feb 8, 2024 · 73062f7 · 73062f7
1 parent 2f455bf
commit 73062f7
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 8 deletions.
diff --git a/openmetadata-spec/src/main/antlr4/org/openmetadata/schema/EntityLink.g4 b/openmetadata-spec/src/main/antlr4/org/openmetadata/schema/EntityLink.g4
@@ -120,6 +120,7 @@ ENTITY_FIELD
     | 'testCaseResult'
     | 'tests'
     | 'pipelineStatus'
+    | 'dataProducts'
     ;
 
 

diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/creating-ingestion.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/creating-ingestion.svg
diff --git a/openmetadata-ui/src/main/resources/ui/src/assets/svg/deploy-ingestion.svg b/openmetadata-ui/src/main/resources/ui/src/assets/svg/deploy-ingestion.svg
diff --git a/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx b/openmetadata-ui/src/main/resources/ui/src/components/LoginButton/LoginButton.tsx
@@ -19,7 +19,7 @@ import './login-button.style.less';
 
 interface LoginButtonProps {
   ssoBrandName: string;
-  ssoBrandLogo?: SvgComponent;
+  ssoBrandLogo?: string;
   onClick?: () => void;
 }
 
@@ -28,18 +28,26 @@ const LoginButton = ({
   ssoBrandLogo,
   onClick,
 }: LoginButtonProps) => {
+  const getImageElement = () => (
+    <img
+      alt={`${ssoBrandName} Logo`}
+      height="30px"
+      src={ssoBrandLogo}
+      width="30px"
+    />
+  );
+
   const svgIcon = ssoBrandLogo ? (
     <Icon
       alt={`${ssoBrandName} Logo`}
       className="align-middle"
-      component={ssoBrandLogo}
-      style={{ fontSize: '30px' }}
+      component={getImageElement}
     />
   ) : null;
 
   return (
     <Button className="signin-button m-x-auto" icon={svgIcon} onClick={onClick}>
-      <span className="font-medium text-grey-muted text-xl">
+      <span className="font-medium text-grey-muted text-xl m-l-0">
         {t('label.sign-in-with-sso', { sso: ssoBrandName })}
       </span>
     </Button>

diff --git a/...ources/ui/src/components/Modals/DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx b/...ources/ui/src/components/Modals/DeployIngestionLoaderModal/DeployIngestionLoaderModal.tsx
@@ -64,7 +64,7 @@ const DeployIngestionLoaderModal = ({
                   <Icon
                     className="align-middle"
                     component={IconCreateIngestion}
-                    style={{ fontSize: '16px' }}
+                    style={{ fontSize: '26px' }}
                   />
                 </Typography.Text>
               </Typography.Text>
@@ -79,7 +79,7 @@ const DeployIngestionLoaderModal = ({
                   <Icon
                     className="align-middle"
                     component={IconDeployIngestion}
-                    style={{ fontSize: '16px' }}
+                    style={{ fontSize: '26px' }}
                   />
                 </Typography.Text>
               </Typography.Text>