Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sso logo breaking due to antd icons component #15083

Merged
merged 8 commits into from
Feb 8, 2024
Merged

fix sso logo breaking due to antd icons component #15083

merged 8 commits into from
Feb 8, 2024

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Feb 8, 2024 •
edited
Loading

Describe your changes:

  • I worked on fixing sso logo breaking due to antd icons component due to recent changes.

Issue :
image

Screenshot 2024-02-08 at 2 58 40 PM

Resolved :

image Screenshot 2024-02-08 at 2 53 44 PM

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Feb 8, 2024
@Ashish8689 Ashish8689 self-assigned this Feb 8, 2024
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Feb 8, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 58%
 58.59% (30087/51352) 38.98% (12092/31018) 38.63% (3669/9497)

chirag-madlani
chirag-madlani previously approved these changes Feb 8, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Ashish8689 Ashish8689 merged commit 73062f7 into main Feb 8, 2024
16 checks passed
@Ashish8689 Ashish8689 deleted the sso-logo-breaking branch February 8, 2024 15:45
Ashish8689 added a commit that referenced this pull request Feb 22, 2024
@Ashish8689
fix sso logo breaking due to antd icons component (#15083)
719903c 
* fix sso logo breaking due to antd icons component

* fix sonar issue

* fix deploy ingestion icon

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
(cherry picked from commit 73062f7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 left review comments

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@Ashish8689 Ashish8689

Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ashish8689 @chirag-madlani @ShaileshParmar11