Fixed NaN values in Cost Analysis aggregate APIs (#13708)

* fixed nan in aggregations * review comments
open-metadata · Oct 25, 2023 · b89f5ea · b89f5ea
1 parent 452a33b
commit b89f5ea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/...ava/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsCountAggregator.java b/...ava/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsCountAggregator.java
@@ -26,9 +26,12 @@ public List<Object> aggregate() throws ParseException {
       Double used = Objects.requireNonNullElse(getValue(totalUsed), 0.0);
       Double unused = Objects.requireNonNullElse(getValue(totalUnused), 0.0);
       Double total = used + unused;
-      Double usedPercentage = used / total;
-      Double unusedPercentage = unused / total;
-
+      Double usedPercentage = 0.0;
+      Double unusedPercentage = 0.0;
+      if (total != 0.0) {
+        usedPercentage = used / total;
+        unusedPercentage = unused / total;
+      }
       data.add(
           new AggregatedUsedVsUnusedAssetsCount()
               .withTimestamp(timestamp)

diff --git a/...java/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsSizeAggregator.java b/...java/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsSizeAggregator.java
@@ -25,9 +25,12 @@ public List<Object> aggregate() throws ParseException {
       Double used = Objects.requireNonNullElse(getValue(totalUsed), 0.0);
       Double unused = Objects.requireNonNullElse(getValue(totalUnused), 0.0);
       Double total = used + unused;
-      Double usedPercentage = used / total;
-      Double unusedPercentage = unused / total;
-
+      Double usedPercentage = 0.0;
+      Double unusedPercentage = 0.0;
+      if (total != 0.0) {
+        usedPercentage = used / total;
+        unusedPercentage = unused / total;
+      }
       data.add(
           new AggregatedUsedVsUnusedAssetsSize()
               .withTimestamp(timestamp)