Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed NaN values in Cost Analysis aggregate APIs #13708

Merged
merged 3 commits into from
Oct 25, 2023
Merged

Fixed NaN values in Cost Analysis aggregate APIs #13708

merged 3 commits into from
Oct 25, 2023

Conversation

OnkarVO7
Copy link
Contributor

Describe your changes:

Fixed NaN values in Cost Analysis aggregate APIs

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@OnkarVO7 OnkarVO7 requested a review from a team as a code owner October 25, 2023 15:36
@OnkarVO7 OnkarVO7 requested a review from TeddyCr October 25, 2023 15:37
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Oct 25, 2023
TeddyCr
TeddyCr reviewed Oct 25, 2023
View reviewed changes
...n/java/org/openmetadata/service/dataInsight/AggregatedUsedvsUnusedAssetsCountAggregator.java Outdated

Double usedPercentage = 0.0;
Double unusedPercentage = 0.0;
if(total != 0){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think total will be a Double, it will probably be 0.0

@github-actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@OnkarVO7 OnkarVO7 requested a review from TeddyCr October 25, 2023 15:44
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@pmbrull pmbrull merged commit b89f5ea into main Oct 25, 2023
11 of 14 checks passed
@pmbrull pmbrull deleted the agg_nan_fix branch October 25, 2023 18:48
akash-jain-10 pushed a commit that referenced this pull request Oct 26, 2023
@OnkarVO7 @akash-jain-10
Fixed NaN values in Cost Analysis aggregate APIs (#13708)
da6a522 
* fixed nan in aggregations

* review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarVO7 @TeddyCr @pmbrull