GEN-1226: Add display name field in the advanced search filter (#17829)

* Add display name filter field for advanced search * Localization changes * Update advanced search tests to include display name filter checks * Fix the failing playwright tests * localization changes * Fix flaky tests --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
open-metadata · Sep 24, 2024 · f21bb16 · f21bb16
1 parent b3bfa64
commit f21bb16
Show file tree

Hide file tree

Showing 23 changed files with 356 additions and 192 deletions.
diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/ActivityFeed.spec.ts
@@ -142,7 +142,7 @@ test.describe('Activity feed', () => {
 
   test('Assigned task should appear to task tab', async ({ page }) => {
     const value: TaskDetails = {
-      term: entity.entity.name,
+      term: entity.entity.displayName,
       assignee: user1.responseData.name,
     };
     await redirectToHomePage(page);
@@ -310,7 +310,7 @@ test.describe('Activity feed', () => {
 
   test('Update Description Task on Columns', async ({ page }) => {
     const firstTaskValue: TaskDetails = {
-      term: entity4.entity.name,
+      term: entity4.entity.displayName,
       assignee: user1.responseData.name,
       description: 'Column Description 1',
       columnName: entity4.entity.columns[0].name,
@@ -379,7 +379,7 @@ test.describe('Activity feed', () => {
 
   test('Comment and Close Task should work in Task Flow', async ({ page }) => {
     const value: TaskDetails = {
-      term: entity2.entity.name,
+      term: entity2.entity.displayName,
       assignee: user1.responseData.name,
     };
     await redirectToHomePage(page);
@@ -441,7 +441,7 @@ test.describe('Activity feed', () => {
 
   test('Open and Closed Task Tab', async ({ page }) => {
     const value: TaskDetails = {
-      term: entity3.entity.name,
+      term: entity3.entity.displayName,
       assignee: user1.responseData.name,
     };
     await redirectToHomePage(page);
@@ -515,7 +515,7 @@ test.describe('Activity feed', () => {
     page,
   }) => {
     const value: TaskDetails = {
-      term: entity4.entity.name,
+      term: entity4.entity.displayName,
       assignee: user1.responseData.name,
     };
     await redirectToHomePage(page);
@@ -634,7 +634,7 @@ base.describe('Activity feed with Data Consumer User', () => {
       await performUserLogin(browser, user2);
 
     const value: TaskDetails = {
-      term: entity.entity.name,
+      term: entity.entity.displayName,
       assignee: user2.responseData.name,
     };
 
@@ -767,7 +767,7 @@ base.describe('Activity feed with Data Consumer User', () => {
       await performUserLogin(browser, user2);
 
     const value: TaskDetails = {
-      term: entity2.entity.name,
+      term: entity2.entity.displayName,
       assignee: user2.responseData.name,
     };
 
@@ -946,7 +946,7 @@ base.describe('Activity feed with Data Consumer User', () => {
         await performUserLogin(browser, viewAllUser);
 
       const value: TaskDetails = {
-        term: entity3.entity.name,
+        term: entity3.entity.displayName,
         assignee: viewAllUser.responseData.name,
       };
 

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AdvancedSearch.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/AdvancedSearch.spec.ts
@@ -105,6 +105,10 @@ test.describe('Advanced Search', { tag: '@advanced-search' }, () => {
         table2.schema.name,
       ],
       'columns.name.keyword': ['email', 'shop_id'],
+      'displayName.keyword': [
+        table1.entity.displayName,
+        table2.entity.displayName,
+      ],
     };
 
     await afterAction();

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/QueryEntity.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/QueryEntity.spec.ts
@@ -37,8 +37,8 @@ const queryData = {
   tagFqn: 'PersonalData.Personal',
   tagName: 'Personal',
   queryUsedIn: {
-    table1: table2.entity.name,
-    table2: table3.entity.name,
+    table1: table2.entity.displayName,
+    table2: table3.entity.displayName,
   },
 };
 

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/RecentlyViewed.spec.ts b/openmetadata-ui/src/main/resources/ui/playwright/e2e/Features/RecentlyViewed.spec.ts
@@ -23,6 +23,7 @@ import { StoredProcedureClass } from '../../support/entity/StoredProcedureClass'
 import { TableClass } from '../../support/entity/TableClass';
 import { TopicClass } from '../../support/entity/TopicClass';
 import { createNewPage, redirectToHomePage } from '../../utils/common';
+import { getEntityDisplayName } from '../../utils/entity';
 
 const entities = [
   new ApiEndpointClass(),
@@ -79,7 +80,9 @@ test.describe('Recently viewed data assets', () => {
 
           await page.waitForSelector(`[data-testid="recently-viewed-widget"]`);
 
-          const selector = `[data-testid="recently-viewed-widget"] [title="${entity.entity.name}"]`;
+          const selector = `[data-testid="recently-viewed-widget"] [title="${getEntityDisplayName(
+            entity.entity
+          )}"]`;
 
           await expect(page.locator(selector)).toBeVisible();
         }

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/support/entity/TableClass.ts b/openmetadata-ui/src/main/resources/ui/playwright/support/entity/TableClass.ts
@@ -98,6 +98,7 @@ export class TableClass extends EntityClass {
 
   entity = {
     name: `pw-table-${uuid()}`,
+    displayName: `pw table ${uuid()}`,
     description: 'description',
     columns: this.children,
     databaseSchema: `${this.service.name}.${this.database.name}.${this.schema.name}`,

diff --git a/openmetadata-ui/src/main/resources/ui/playwright/tsconfig.json b/openmetadata-ui/src/main/resources/ui/playwright/tsconfig.json
@@ -0,0 +1,32 @@
+{
+  "compilerOptions": {
+    "incremental": true,
+    "target": "ES5",
+    "module": "esnext",
+    "lib": ["dom", "dom.iterable", "ES2020.Promise", "es2021"],
+    "allowJs": true,
+    "jsx": "react",
+    "declaration": true,
+    "declarationMap": true,
+    "sourceMap": true,
+    "composite": false,
+    "removeComments": false,
+    "noEmit": true,
+    "importHelpers": true,
+    "downlevelIteration": true,
+    "isolatedModules": true,
+    "strict": true,
+    "noUnusedLocals": true,
+    "noUnusedParameters": true,
+    "noImplicitReturns": true,
+    "noFallthroughCasesInSwitch": true,
+    "moduleResolution": "node",
+    "resolveJsonModule": true,
+    "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true,
+    "forceConsistentCasingInFileNames": true,
+    "allowUnreachableCode": false,
+    "skipLibCheck": true,
+    "noImplicitAny": true
+  }
+}