Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GEN-1226: Add display name field in the advanced search filter #17829

Merged
merged 18 commits into from
Sep 24, 2024
Merged

GEN-1226: Add display name field in the advanced search filter #17829

merged 18 commits into from
Sep 24, 2024

Conversation

aniketkatkar97
Copy link
Member

@aniketkatkar97 aniketkatkar97 commented Sep 12, 2024 •
edited
Loading

I worked on the following:

  • Add a display name field in the advanced search filter.
  • Add regular expression operator in advanced search
  • Fix and update advanced search playwright tests
Screen.Recording.2024-09-16.at.9.03.04.PM.mov

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Sep 12, 2024
@aniketkatkar97 aniketkatkar97 self-assigned this Sep 12, 2024
@aniketkatkar97 aniketkatkar97 marked this pull request as draft September 12, 2024 17:45
@github-actions github-actions bot added e2e:DataAssets safe to test Add this label to run secure Github workflows on PRs labels Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 64%
 64.35% (37413/58142) 41.02% (14843/36186) 43.1% (4512/10469)

@cypress Cypress
Copy link

cypress bot commented Sep 12, 2024

openmetadata    Run #34949

Run Properties:  status check no tests Notests #34949  •  git commit f9c5ca3525: Localization changes
Project openmetadata
Branch Review feat-GEN-1226
Run status status check no tests Notests #34949
Run duration 01m 13s
Commit git commit f9c5ca3525: Localization changes
Committer Aniket Katkar
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 1
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 0
View all changes introduced in this branch ↗︎

karanh37
karanh37 previously approved these changes Sep 24, 2024
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@aniketkatkar97 aniketkatkar97 merged commit f21bb16 into main Sep 24, 2024
17 checks passed
@aniketkatkar97 aniketkatkar97 deleted the feat-GEN-1226 branch September 24, 2024 19:21
@aniketkatkar97 aniketkatkar97 mentioned this pull request Sep 25, 2024
Closed
aniketkatkar97 added a commit that referenced this pull request Oct 14, 2024
@aniketkatkar97 @chirag-madlani
GEN-1226: Add display name field in the advanced search filter (#17829)
d65c9ce 
* Add display name filter field for advanced search

* Localization changes

* Update advanced search tests to include display name filter checks

* Fix the failing playwright tests

* localization changes

* Fix flaky tests

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShaileshParmar11 ShaileshParmar11 ShaileshParmar11 approved these changes

@karanh37 karanh37 karanh37 left review comments

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniketkatkar97 @karanh37 @ShaileshParmar11 @chirag-madlani