Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: add soft delete option for services and limit actions for soft deleted entities #12833

Closed
2 tasks
aniketkatkar97 opened this issue Aug 10, 2023 · 1 comment · Fixed by #13824
Closed
2 tasks

ui: add soft delete option for services and limit actions for soft deleted entities #12833

aniketkatkar97 opened this issue Aug 10, 2023 · 1 comment · Fixed by #13824
Assignees
@aniketkatkar97
Labels
UI UI specific issues

Comments

@aniketkatkar97
Copy link
Member

Affected module
Does it impact the UI, backend or Ingestion Framework?
UI

Describe the bug
A clear and concise description of what the bug is.

  • Add soft delete option for services.
  • Limit the actions for all the soft deleted entities. We should not allow actions such as edit owner, tier, etc. The entity details should have read-only view when soft deleted.

To Reproduce

Screenshots or steps to reproduce

Expected behavior
A clear and concise description of what you expected to happen.

Version:

  • OS: [e.g. iOS]
  • Python version:
  • OpenMetadata version: [e.g. 0.8]
  • OpenMetadata Ingestion package version: [e.g. openmetadata-ingestion[docker]==XYZ]

Additional context
Add any other context about the problem here.
@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Aug 10, 2023
@aniketkatkar97 aniketkatkar97 self-assigned this Aug 10, 2023
@chirag-madlani
Copy link
Collaborator

@aniketkatkar97 Let's close it for 1.2.1

@aniketkatkar97 aniketkatkar97 mentioned this issue Nov 9, 2023
Merged
18 tasks
chirag-madlani added a commit that referenced this issue Nov 10, 2023
@aniketkatkar97 @chirag-madlani
fix(ui)#12833: soft delete service and edit action restrictions after…
ba35e1e 
… soft delete (#13824)

* Added soft delete option for services

* disabled edit actions for deleted entities
fixed code smells
code refactoring

* added loading icon in restore entity modal while API call is pending

* fixed code smells

* localization changes

* changes to make actions disabled for deleted entities

* fixed code smell

* changes to limit actions for soft deleted teams

* localization changes

* added deleted badge for soft deleted teams

* Fixed unit tests

* improved delete modal functionality
limited actions for deleted tables on profiler tab

* fixed failing unit tests

* added missing up vote and down vote functionality for search Index entities

* updated the logic to show display name if available in search suggestions

* fixed custom properties settings page bug
added soft delete limitations for container and search index custom property tab

* fixed unit tests

* fixed bugs on table details page and container details page

* Fixed bug on team details page

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
aniketkatkar97 added a commit that referenced this issue Nov 10, 2023
@aniketkatkar97 @chirag-madlani
fix(ui)#12833: soft delete service and edit action restrictions after…
48996fa 
… soft delete (#13824)

* Added soft delete option for services

* disabled edit actions for deleted entities
fixed code smells
code refactoring

* added loading icon in restore entity modal while API call is pending

* fixed code smells

* localization changes

* changes to make actions disabled for deleted entities

* fixed code smell

* changes to limit actions for soft deleted teams

* localization changes

* added deleted badge for soft deleted teams

* Fixed unit tests

* improved delete modal functionality
limited actions for deleted tables on profiler tab

* fixed failing unit tests

* added missing up vote and down vote functionality for search Index entities

* updated the logic to show display name if available in search suggestions

* fixed custom properties settings page bug
added soft delete limitations for container and search index custom property tab

* fixed unit tests

* fixed bugs on table details page and container details page

* Fixed bug on team details page

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
ulixius9 pushed a commit that referenced this issue Nov 10, 2023
@aniketkatkar97 @chirag-madlani @ulixius9
fix(ui)#12833: soft delete service and edit action restrictions after…
5932d49 
… soft delete (#13824)

* Added soft delete option for services

* disabled edit actions for deleted entities
fixed code smells
code refactoring

* added loading icon in restore entity modal while API call is pending

* fixed code smells

* localization changes

* changes to make actions disabled for deleted entities

* fixed code smell

* changes to limit actions for soft deleted teams

* localization changes

* added deleted badge for soft deleted teams

* Fixed unit tests

* improved delete modal functionality
limited actions for deleted tables on profiler tab

* fixed failing unit tests

* added missing up vote and down vote functionality for search Index entities

* updated the logic to show display name if available in search suggestions

* fixed custom properties settings page bug
added soft delete limitations for container and search index custom property tab

* fixed unit tests

* fixed bugs on table details page and container details page

* Fixed bug on team details page

---------

Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aniketkatkar97 aniketkatkar97

Labels
UI UI specific issues
Projects
None yet
Milestone
No milestone
2 participants
@chirag-madlani @aniketkatkar97