fix(ui)#12833: soft delete service and edit action restrictions after soft delete #13824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
safe to test
Jest test CoverageUI tests summary
|
limited actions for deleted tables on profiler tab
added soft delete limitations for container and search index custom property tab
aniketkatkar97
requested review from
harshach,
karanh37 and
chirag-madlani
as code owners
harshach
approved these changes
Nov 9, 2023
|
@aniketkatkar97 can we add cypress tests for this |
|
@harshach Yes the tests are almost done. I will raise a separate PR for it. |
| const tasksDAGView = useMemo( | ||
| () => | ||
| !isEmpty(pipelineDetails.tasks) && !isUndefined(pipelineDetails.tasks) ? ( | ||
| <Card headStyle={{ background: '#fafafa' }} title={t('label.dag-view')}> |
There was a problem hiding this comment.
Can we avoid inline staying?
openmetadata-ui/src/main/resources/ui/src/components/TableQueries/TableQueries.tsx
Show resolved
Hide resolved
| /> | ||
| </Space> | ||
| </Col> | ||
| {!currentTeam.deleted && ( |
There was a problem hiding this comment.
Suggested change
| {!currentTeam.deleted && ( | |
| {!isTeamDeleted && ( |
...adata-ui/src/main/resources/ui/src/components/Team/TeamDetails/UserTab/UserTab.component.tsx
Show resolved
Hide resolved
| <Input | ||
| autoComplete="off" | ||
| data-testid="confirmation-text-input" | ||
| disabled={entityDeleteState.loading === 'waiting'} |
There was a problem hiding this comment.
Can we use autoFocus prop to make it focus instead manual code?
| @@ -126,7 +126,7 @@ const CustomEntityDetailV1 = () => { | |||
| setIsButtonLoading(false); | |||
| } | |||
| }, | |||
| [selectedEntityTypeDetail.id] | |||
| [selectedEntityTypeDetail] | |||
There was a problem hiding this comment.
Why we change this? Can you add details of it?
There was a problem hiding this comment.
So we are using selectedEntityTypeDetail, as well inside the function, and the other data was not updating due to the specified dependancy
| getDatabaseSchemas( | ||
| const fetchDatabaseSchemas = async (pagingObj?: string) => { | ||
| try { | ||
| const response = await getDatabaseSchemas( |
There was a problem hiding this comment.
Suggested change
| const response = await getDatabaseSchemas( | |
| setSchemaDataLoading(true); | |
| const response = await getDatabaseSchemas( |
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
|
[open-metadata-ui] Kudos, SonarCloud Quality Gate passed! |
chirag-madlani
had a problem deploying
to
test
GitHub Actions
Failure
aniketkatkar97
added a commit
that referenced
this pull request
Nov 10, 2023
… soft delete (#13824) * Added soft delete option for services * disabled edit actions for deleted entities fixed code smells code refactoring * added loading icon in restore entity modal while API call is pending * fixed code smells * localization changes * changes to make actions disabled for deleted entities * fixed code smell * changes to limit actions for soft deleted teams * localization changes * added deleted badge for soft deleted teams * Fixed unit tests * improved delete modal functionality limited actions for deleted tables on profiler tab * fixed failing unit tests * added missing up vote and down vote functionality for search Index entities * updated the logic to show display name if available in search suggestions * fixed custom properties settings page bug added soft delete limitations for container and search index custom property tab * fixed unit tests * fixed bugs on table details page and container details page * Fixed bug on team details page --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
ulixius9
pushed a commit
that referenced
this pull request
Nov 10, 2023
… soft delete (#13824) * Added soft delete option for services * disabled edit actions for deleted entities fixed code smells code refactoring * added loading icon in restore entity modal while API call is pending * fixed code smells * localization changes * changes to make actions disabled for deleted entities * fixed code smell * changes to limit actions for soft deleted teams * localization changes * added deleted badge for soft deleted teams * Fixed unit tests * improved delete modal functionality limited actions for deleted tables on profiler tab * fixed failing unit tests * added missing up vote and down vote functionality for search Index entities * updated the logic to show display name if available in search suggestions * fixed custom properties settings page bug added soft delete limitations for container and search index custom property tab * fixed unit tests * fixed bugs on table details page and container details page * Fixed bug on team details page --------- Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #12833
I worked on adding edit action checks for soft-deleted entities for the following entities:
Screen.Recording.2023-11-09.at.7.34.57.PM.mov
Screen.Recording.2023-11-09.at.7.42.39.PM.mov
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>