Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation in ingestion pipeline json schema to not include whitespace #13190

Closed
OnkarVO7 opened this issue Sep 14, 2023 · 3 comments · Fixed by #14403
Closed

Add validation in ingestion pipeline json schema to not include whitespace #13190

OnkarVO7 opened this issue Sep 14, 2023 · 3 comments · Fixed by #14403
Assignees

Comments

@OnkarVO7
Copy link
Contributor

Describe the bug
Below error gets generated when we have a whitespace in the ingestion pipeline name. The logs do not get displayed.
image

We'll add validation in ingestion pipeline json schema to not include whitespace chars.

@ayush-shah ayush-shah added the UI UI specific issues label Oct 19, 2023
@harshach harshach moved this to Backend - Bugs & Minor Features in Release 1.3.0 Oct 22, 2023
@pmbrull pmbrull assigned pmbrull and unassigned harshach Dec 12, 2023
@pmbrull
Copy link
Collaborator

pmbrull commented Dec 13, 2023

let's fix this by validating how we can clean the API call retrieving the logs

@chirag-madlani
Copy link
Collaborator

@pmbrull should we restrict space in the ingestion name to fix this?

@pmbrull
Copy link
Collaborator

pmbrull commented Dec 15, 2023

hi we should allow spaces here. I'll fix the API to get this working, thanks!

Tested in Collate and it's fine there, so the issue is Airflow-specific.

@pmbrull pmbrull removed the UI UI specific issues label Dec 15, 2023
pmbrull added a commit to pmbrull/OpenMetadata that referenced this issue Dec 15, 2023
pmbrull added a commit that referenced this issue Dec 19, 2023
* #13190 - Improve URL handling for Airflow REST Client

* Fmt

* Format
@TeddyCr TeddyCr moved this from Backend - Bugs & Minor Features to Done in Release 1.3.0 Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants