Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#13190 - Improve URL handling for Airflow REST Client #14403

Merged
merged 5 commits into from
Dec 19, 2023
Merged

#13190 - Improve URL handling for Airflow REST Client #14403

merged 5 commits into from
Dec 19, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Dec 15, 2023

Describe your changes:

Fixes #13190

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@pmbrull pmbrull requested a review from a team as a code owner December 15, 2023 11:40
@github-actions github-actions bot added backend Ingestion safe to test Add this label to run secure Github workflows on PRs labels Dec 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

ayush-shah
ayush-shah approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@ayush-shah ayush-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm Thanks!

@pmbrull pmbrull merged commit fac1896 into open-metadata:main Dec 19, 2023
16 checks passed
@pmbrull pmbrull deleted the issue-13190 branch December 19, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohityadav766 mohityadav766 mohityadav766 approved these changes

@ayush-shah ayush-shah ayush-shah approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add validation in ingestion pipeline json schema to not include whitespace
3 participants
@pmbrull @ayush-shah @mohityadav766