Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version page breaks on adding column display name #14363

Closed
ulixius9 opened this issue Dec 13, 2023 · 2 comments · Fixed by #14474
Closed

Version page breaks on adding column display name #14363

ulixius9 opened this issue Dec 13, 2023 · 2 comments · Fixed by #14474
Assignees
@aniketkatkar97
Labels
bug Something isn't working UI UI specific issues

Comments

@ulixius9
Copy link
Member

Affected module
UI

Describe the bug
When the display name field of column is populated the version page breaks on UI with following error

image

image
@ulixius9 ulixius9 added bug Something isn't working UI UI specific issues labels Dec 13, 2023
@ulixius9 ulixius9 changed the title Version page break on adding column display name Version page breaks on adding column display name Dec 13, 2023
@ulixius9
Copy link
Member Author

also the task names are not visible in pipeline version page.

image

@chirag-madlani chirag-madlani moved this to UI - Bugs & Minor Features in Release 1.3.0 Dec 14, 2023
@harshach harshach removed this from Release 1.3.0 Dec 19, 2023
@aniketkatkar97
Copy link
Member

@ulixius9 Can you also please add the steps to reproduce the issue with the pipeline version page?

@aniketkatkar97 aniketkatkar97 mentioned this issue Dec 21, 2023
Merged
7 tasks
chirag-madlani pushed a commit that referenced this issue Dec 21, 2023
@aniketkatkar97
#14363: Fixed version page breaking issue for Table and Pipeline asse…
0a3b03b 
…ts. (#14474)

* Fixed column displayName change resulting in error on table version page

* fixed pipeline name not showing on pipeline version page

* added unit tests for fixed table and pipeline version pages

* Wrapped edit displayName icon with button component

* added cypress tests for the fixed version page bugs for table and pipeline version pages
aniketkatkar97 added a commit that referenced this issue Dec 21, 2023
@aniketkatkar97
#14363: Fixed version page breaking issue for Table and Pipeline asse…
95c68f1 
…ts. (#14474)

* Fixed column displayName change resulting in error on table version page

* fixed pipeline name not showing on pipeline version page

* added unit tests for fixed table and pipeline version pages

* Wrapped edit displayName icon with button component

* added cypress tests for the fixed version page bugs for table and pipeline version pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aniketkatkar97 aniketkatkar97

Labels
bug Something isn't working UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#14363: Fixed version page breaking issue for Table and Pipeline assets. open-metadata/OpenMetadata
2 participants
@ulixius9 @aniketkatkar97