Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#14363: Fixed version page breaking issue for Table and Pipeline assets. #14474

Merged
merged 5 commits into from
Dec 21, 2023
Merged

#14363: Fixed version page breaking issue for Table and Pipeline assets. #14474

merged 5 commits into from
Dec 21, 2023

Conversation

aniketkatkar97
Copy link
Member

Describe your changes:

Fixes #14363

I worked on fixing the following bugs:

  • Fixed Table version page breaking when column display name changes are present.
Screen.Recording.2023-12-21.at.6.36.51.PM.mov
  • Fixed pipeline names not showing on the Pipeline version page
Screenshot 2023-12-21 at 6 36 36 PM

Type of change:

  • Bug fix

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 added UI UI specific issues e2e This will trigger e2e test workflows labels Dec 21, 2023
@aniketkatkar97 aniketkatkar97 requested a review from a team December 21, 2023 13:12
@aniketkatkar97 aniketkatkar97 self-assigned this Dec 21, 2023
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Dec 21, 2023
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 50.01% (24994/49977) 32.82% (9876/30093) 31.19% (2839/9102)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@cypress Cypress
Copy link

cypress bot commented Dec 21, 2023 •
edited
Loading

16 failed tests on run #32693 ↗︎

16 480 8 0 Flakiness 0

Details:

added cypress tests for the fixed version page bugs for table and pipeline versi...
Project: openmetadata Commit: bad62c67d5
Status: Failed Duration: 50:49 💡
Started: Dec 21, 2023 1:31 PM Ended: Dec 21, 2023 2:22 PM
Failed  Service/postgres.spec.js • 1 failed test • cypress-ci-psql-oss-7288594245-1

View Output Video

Test Artifacts
Postgres Ingestion > Update table description and verify description after re-run Screenshots Video
Failed  Pages/SearchIndexDetails.spec.js • 2 failed tests • cypress-ci-psql-oss-7288594245-1

View Output Video

Test Artifacts
SearchIndexDetails page should work properly for data steward role > All permissible actions on search index details page should work properly Screenshots Video
SearchIndexDetails page should work properly for admin role > All permissible actions on search index details page should work properly Screenshots Video
Failed  Pages/Users.spec.js • 3 failed tests • cypress-ci-psql-oss-7288594245-1

View Output Video

Test Artifacts
Users flow should work properly > Soft delete user Screenshots Video
Users flow should work properly > Restore soft deleted user Screenshots Video
Users flow should work properly > Permanently Delete Soft Deleted User Screenshots Video
Failed  Service/mysql.spec.js • 1 failed test • cypress-ci-psql-oss-7288594245-1

View Output Video

Test Artifacts
MySQL Ingestion > Update table description and verify description after re-run Screenshots Video
Failed  Service/superset.spec.js • 1 failed test • cypress-ci-psql-oss-7288594245-1

View Output Video

Test Artifacts
Superset Ingestion > Update table description and verify description after re-run Screenshots Video

The first 5 failed specs are shown, see all 10 specs in Cypress Cloud.

Review all test suite changes for PR #14474 ↗︎

@chirag-madlani chirag-madlani merged commit 0a3b03b into main Dec 21, 2023
20 of 30 checks passed
@chirag-madlani chirag-madlani deleted the fix-14363 branch December 21, 2023 15:23
aniketkatkar97 added a commit that referenced this pull request Dec 21, 2023
@aniketkatkar97
#14363: Fixed version page breaking issue for Table and Pipeline asse…
95c68f1 
…ts. (#14474)

* Fixed column displayName change resulting in error on table version page

* fixed pipeline name not showing on pipeline version page

* added unit tests for fixed table and pipeline version pages

* Wrapped edit displayName icon with button component

* added cypress tests for the fixed version page bugs for table and pipeline version pages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@aniketkatkar97 aniketkatkar97

Labels
e2e This will trigger e2e test workflows safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version page breaks on adding column display name
2 participants
@aniketkatkar97 @chirag-madlani