Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When an Ingestion job has failures and it calls the Airflow callback send_failed_status_callback errors #14859

Closed
IceS2 opened this issue Jan 25, 2024 · 0 comments · Fixed by #14894
Assignees
Labels
bug Something isn't working Ingestion

Comments

@IceS2
Copy link
Contributor

IceS2 commented Jan 25, 2024

Affected module
Ingestion Framework

Describe the bug
When an ingestion job has failures, the Airflow callback errors.

Traceback (most recent call last):
  File "/home/airflow/.local/lib/python3.10/site-packages/airflow/models/taskinstance.py", line 1702, in _run_finished_callback
    callback(context)
TypeError: send_failed_status_callback() takes 2 positional arguments but 3 were given

To Reproduce

We can reproduce the error by:

  1. Creating a new MySQL Connector pointing to the OpenMetadata database (using the docker-compose from development)
  2. Triggering an Ingestion Job
  3. Killing it fast as soon as it starts running

Then it takes a while to fetch the logs through the UI but you should see the error described.

Expected behavior
The Airflow callback does not fail.

Version:

  • OS: macOS
  • Python version: 3.9
  • OpenMetadata version: main
  • OpenMetadata Ingestion package version: 1.3.0

Additional context

@IceS2 IceS2 added bug Something isn't working Ingestion labels Jan 25, 2024
pmbrull added a commit to pmbrull/OpenMetadata that referenced this issue Jan 26, 2024
@pmbrull pmbrull moved this to Done in Release 1.3.0 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Ingestion
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants