Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#14859 - Fix signature of status callback #14894

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Jan 26, 2024

Describe your changes:

Fixes #14859

Getting clean callback calls now

metadata.config.common.WorkflowExecutionError: Mysql reported errors: Mysql Summary: [3 Records, [0 Updated Records, 0 Warnings, 1 Errors, 0 Filtered]
[2024-01-26T14:32:38.089+0000] {taskinstance.py:1400} INFO - Marking task as FAILED. dag_id=mysql_metadata_jhqKi5Au, task_id=ingestion_task, execution_date=20240126T143207, start_date=20240126T143210, end_date=20240126T143238
[2024-01-26T14:32:38.089+0000] {common.py:283} INFO - Sending failed status from callback...
[2024-01-26T14:32:38.094+0000] {server_mixin.py:66} INFO - OpenMetadata client running with Server version [1.3.0] and Client version [1.3.0.0]
[2024-01-26T14:32:38.095+0000] {common.py:289} INFO - Sending status to Ingestion Pipeline mysql.mysql_metadata_jhqKi5Au
[2024-01-26T14:32:38.125+0000] {standard_task_runner.py:104} ERROR - Failed to execute job 4 for task ingestion_task (Mysql reported errors: Mysql Summary: [3 Records, [0 Updated Records, 0 Warnings, 1 Errors, 0 Filtered]; 3771)
[2024-01-26T14:32:38.191+0000] {local_task_job_runner.py:228} INFO - Task exited with return code 1
[2024-01-26T14:32:38.205+0000] {taskinstance.py:2778} INFO - 0 downstream tasks scheduled from follow-on schedule check

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions github-actions bot added Ingestion safe to test Add this label to run secure Github workflows on PRs labels Jan 26, 2024
@pmbrull pmbrull requested a review from a team January 26, 2024 14:36
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-airflow-apis'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmbrull pmbrull merged commit 6d6db4b into open-metadata:main Jan 26, 2024
11 of 12 checks passed
@pmbrull pmbrull deleted the issue-14859 branch January 26, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When an Ingestion job has failures and it calls the Airflow callback send_failed_status_callback errors
2 participants