Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ui): stored procedure ui changes #13102

Merged
merged 4 commits into from
Sep 8, 2023
Merged

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Sep 6, 2023

Describe your changes:

Fixes #12998

  • Switch the tab to 2nd place in Database schema page
  • Change name to plural of stored procedure
  • supported recent view for stored procedure
  • supported source url in heading
  • fix the api params name to databaseSchema
image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 6, 2023
@Ashish8689 Ashish8689 requested a review from harshach as a code owner September 6, 2023 10:00
@Ashish8689 Ashish8689 self-assigned this Sep 6, 2023
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 10:00 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 10:00 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 10:00 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 10:00 — with GitHub Actions Inactive
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
49.78% (20933/42049) 29.89% (7551/25259) 30.59% (2371/7750)

@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 11:00 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 11:00 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 11:00 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 6, 2023 11:00 — with GitHub Actions Inactive
chirag-madlani
chirag-madlani previously approved these changes Sep 6, 2023
@cypress
Copy link

cypress bot commented Sep 6, 2023

5 failed tests on run #29274 ↗︎

5 398 37 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

fix the params and added source url in heading
Project: openmetadata Commit: babbdd4f32
Status: Failed Duration: 09:43 💡
Started: Sep 8, 2023 6:16 AM Ended: Sep 8, 2023 7:26 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 temporarily deployed to test September 8, 2023 05:53 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 8, 2023 05:53 — with GitHub Actions Inactive
@Sachin-chaurasiya
Copy link
Member

@Ashish8689 , let's add the unit tests for the changes.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Ashish8689
Copy link
Contributor Author

@Sachin-chaurasiya will be adding unit test changes in separate new PR.

@akash-jain-10 akash-jain-10 merged commit 749c718 into main Sep 8, 2023
@akash-jain-10 akash-jain-10 deleted the chore-stored-procedure branch September 8, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Stored Procedures as another entity under Database Schema
5 participants