Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Stored Procedures as another entity under Database Schema #12998

Closed
7 tasks done
harshach opened this issue Aug 25, 2023 · 7 comments · Fixed by #13102, #13194 or #13312
Closed
7 tasks done

Support for Stored Procedures as another entity under Database Schema #12998

harshach opened this issue Aug 25, 2023 · 7 comments · Fixed by #13102, #13194 or #13312
Assignees
Labels

Comments

@harshach
Copy link
Collaborator

harshach commented Aug 25, 2023

Is your feature request related to a problem? Please describe.
Stored Procedures important entity in a database, many users are expressed interest in capturing metadata about stored procedures and potentially lineage

Describe the solution you'd like
We will be adding Stored Procedure as another entity with a parent container as the Database Schema.
There will be APIs under /api/v1/storedProcedures to capture the metadata about Stored Procedures

  • Backend APIs for Stored Procedures
  • Sample Data for Stored Procedures
  • UI support for Stored Procedures
  • Search support for Stored Procedures
  • Ingestion Support
  • Missing aggregation in search
  • cypress for storedProcedure and data models

Related issues

@pmbrull
Copy link
Collaborator

pmbrull commented Sep 6, 2023

Ingestion

For Snowflake:

For Redshift:

For BigQuery:

  • Overview. They are a subset of Routines, which include Stored Procedures, UDFs and Table Functions, so we might be able to generally treat Routines.
  • List Procedures and get their definition. More docs
  • TODO: Check how we might be able to get the executions. Maybe use the JOBS_* tables?

For Postgres:

@pmbrull pmbrull reopened this Sep 8, 2023
pmbrull added a commit that referenced this issue Sep 12, 2023
* Prep Stored Procedures Skeleton for Snowflake

* Update pylint and add migrations

* Fix test

* Reuse source url computation
pmbrull added a commit that referenced this issue Sep 13, 2023
* Fix snowflake SP source url

* Update sourceUrl on PUT

* Add BigQuery Stored Procedures support

* Linting

* Linting

* lint

* Linting
pmbrull added a commit to pmbrull/OpenMetadata that referenced this issue Sep 13, 2023
pmbrull added a commit that referenced this issue Sep 14, 2023
* Part of #12998 - Add Stored Procedures support for Redshift

* Lint

* Fix bq queries

* Update ingestion/src/metadata/ingestion/source/database/bigquery/queries.py
pmbrull added a commit that referenced this issue Sep 19, 2023
…3215)

* Update mapping

* Prep

* prep

* Prep query migration

* Add query index deletion fix

* Docs and Maven CI fix

* Fix tests

* Add service filter

* Add query entity FQN col migration

* Fix lint

* supported serviceFQN in query api

* Prep repo

* Prep ES query search

* Do not recompute lineage

* Format

* Fix test

---------

Co-authored-by: Ashish Gupta <ashish@getcollate.io>
@Ashish8689 Ashish8689 reopened this Sep 20, 2023
@asprdnv
Copy link

asprdnv commented Sep 21, 2023

Hi, will we able to build pipelines and lineage based on stored procedures?

We call procedures in MSSQL Jobs – usually 1 step = 1 procedure

@pmbrull
Copy link
Collaborator

pmbrull commented Sep 29, 2023

hi @asprdnv Stored Procedures are ingested under the Database Schema that they live in. Not sure if we'll have enough room to handle MSSQL for 1.2.0. If not, we'll add them in 1.2.1

@chuqbach
Copy link

Hi, how about Oracle Stored Procedure? Do you have any plan for it?

@nqvuong1998
Copy link

Hi @pmbrull , Do you have any plan to implement Stored Procedure for Oracle?

@ayush-shah
Copy link
Member

Hello @nqvuong1998 Yes, that's is on the roadmap and we plan to bring it in the upcoming release.

@ayush-shah
Copy link
Member

@nqvuong1998 you can track the fix for the same from here: #14641
and the issue for it: #14630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment