Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part of #12998 - Add Stored Procedures support in BigQuery #13160

Merged
merged 8 commits into from
Sep 13, 2023

Conversation

pmbrull
Copy link
Collaborator

@pmbrull pmbrull commented Sep 12, 2023

Describe your changes:

Part of #12998

Note that most of the stuff is similar to Snowflake. I'll be taking a stab to Redshift next and see if there are the same common approaches there. If so, I might prep a mixin to centralize and reuse some of the methods

  • This also fixes the snowflake sourceUrl creation
  • And updates the StoredProcedureRepository to ensure that we can properly update the sourceUrl via PUT

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@pmbrull pmbrull temporarily deployed to test September 12, 2023 17:41 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test September 12, 2023 17:41 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test September 12, 2023 17:41 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test September 12, 2023 17:41 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@cypress
Copy link

cypress bot commented Sep 12, 2023

25 failed tests on run #29558 ↗︎

25 378 37 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Linting
Project: openmetadata Commit: b392976d39
Status: Failed Duration: 29:06 💡
Started: Sep 12, 2023 6:04 PM Ended: Sep 12, 2023 7:34 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@pmbrull pmbrull temporarily deployed to test September 13, 2023 05:20 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test September 13, 2023 05:20 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test September 13, 2023 05:20 — with GitHub Actions Inactive
@pmbrull pmbrull temporarily deployed to test September 13, 2023 05:20 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

[open-metadata-ingestion] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

43.4% 43.4% Coverage
13.9% 13.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@pmbrull pmbrull merged commit 42393f5 into open-metadata:main Sep 13, 2023
@pmbrull pmbrull deleted the bq-stored-proc branch September 13, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants