Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stored procedures, user defined functions, user defined table types as table types #12167

Closed
gavindew opened this issue Jun 27, 2023 · 1 comment · Fixed by #13031
Closed
Assignees
Labels
backend enhancement New feature or request Ingestion UI UI specific issues

Comments

@gavindew
Copy link

Is your feature request related to a problem? Please describe.
We have many stored procedures, user-defined table types and user-defined table functions. We would like to be able to add these to the data catalogue.

Describe the solution you'd like
We would like to be able to send via the API the table definition with the TableType being

  • StoredProcedure
  • UserDefinedTableType
  • TableValuedFunction

We would like to be able to define input parameters. This would be an additional tab on the table page. Input parameters should be able to have tags and glossary items assigned to them, just like columns.

We would like to be able to set the table SQL in the ViewDefinition field.

We would like to be able to view the ViewDefinition on the page.

Making this available only via API (i.e. not needing to update the ingestion adapters) would be a good first start.

Describe alternatives you've considered
As an alternative, we will be defining these artefacts as Views, however, this is not ideal.
We will be defining input parameters using a convention that ensures they are always the first columns such as @ParameterName.

@gavindew gavindew added the enhancement New feature or request label Jun 27, 2023
@harshach harshach self-assigned this Jun 29, 2023
@TeddyCr TeddyCr removed this from Release 1.2 Jun 30, 2023
@harshach harshach added UI UI specific issues backend labels Jul 29, 2023
@pmbrull
Copy link
Collaborator

pmbrull commented Aug 2, 2023

For Snowflake:

For Redshift:

For BigQuery:

  • Overview. They are a subset of Routines, which include Stored Procedures, UDFs and Table Functions, so we might be able to generally treat Routines.
  • List Procedures and get their definition. More docs
  • TODO: Check how we might be able to get the executions. Maybe use the JOBS_* tables?

For Postgres:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend enhancement New feature or request Ingestion UI UI specific issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants