Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): supported code and activity tab in stored procedure #13054

Merged
merged 3 commits into from
Sep 2, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Aug 31, 2023

Describe your changes:

Fixes #12167

  • added code and activity tabs in the Stored Procedure entity
image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Aug 31, 2023
@Ashish8689 Ashish8689 self-assigned this Aug 31, 2023
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 16:31 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 16:31 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 16:31 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 16:31 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 16:31 — with GitHub Actions Inactive
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Aug 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
50.05% (20276/40514) 28.95% (7131/24628) 31.07% (2324/7481)

@cypress
Copy link

cypress bot commented Aug 31, 2023

3 failed tests on run #28865 ↗︎

3 366 37 3 Flakiness 0

Details:

Merge branch 'feat-stored-procedure' into feat-stored-procedure-tabs
Project: openmetadata Commit: 323057e5d7
Status: Failed Duration: 35:04 💡
Started: Sep 1, 2023 9:30 AM Ended: Sep 1, 2023 10:05 AM
Failed  Pages/ServiceVersionPage.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Dashboard service version page > Dashboard version page should show tier changes properly Output Screenshots Video
Failed  AddNewService/postgres.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Output Screenshots Video
Failed  Features/ActivityFeed.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Activity feed > Mention should work for the feed reply Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 1, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Ashish8689 Ashish8689 marked this pull request as ready for review September 1, 2023 09:31
@Ashish8689 Ashish8689 merged commit bc92b28 into feat-stored-procedure Sep 2, 2023
@Ashish8689 Ashish8689 deleted the feat-stored-procedure-tabs branch September 2, 2023 10:50
chirag-madlani pushed a commit that referenced this pull request Sep 4, 2023
* feat: supported stored procedure in database

* minor fixes

* fix sonar

* optimize stored procedure code and supported deleted flag for it

* feat(ui): supported code and activity tab in stored procedure (#13054)

* supported code and activity tab in stored procedure

* added support for task functionality

* feat(ui): supported lineage tab in stored procedure (#13060)

* supported code and activity tab in stored procedure

* added support for task functionality

* feat: supported lineage tab in stored procedure

* feat(ui): supported custom property tab in stored procedure and setting page (#13063)

* feat: supported custom property tab in stored procedure and setting page

* added extension field

* chanegs as per comments

* chanegs as per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants