Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): supported stored procedure in database #13031

Merged
merged 13 commits into from
Sep 4, 2023
Merged

feat(ui): supported stored procedure in database #13031

merged 13 commits into from
Sep 4, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #12167

  • Supported Stored Procedure in Database schema Page
  • Added Partical Details Page for Stored Procedure

In Progress :
image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Aug 29, 2023
@Ashish8689 Ashish8689 self-assigned this Aug 29, 2023
@Ashish8689 Ashish8689 temporarily deployed to test August 29, 2023 13:16 — with GitHub Actions Inactive
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Aug 29, 2023
@cypress
Copy link

cypress bot commented Aug 29, 2023 •
edited
Loading

4 failed tests on run #29002 ↗︎

4 381 37 7 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge branch 'main' into feat-stored-procedure
Project: openmetadata Commit: 75e2968691
Status: Failed Duration: 07:45 💡
Started: Sep 4, 2023 9:03 AM Ended: Sep 4, 2023 10:11 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 12:39 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 12:39 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 12:39 — with GitHub Actions Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Aug 31, 2023 •
edited
Loading

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
 49.52% (20381/41154) 28.71% (7150/24900) 30.68% (2328/7589)

@Ashish8689 Ashish8689 temporarily deployed to test August 31, 2023 15:51 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 06:51 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 06:51 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 06:51 — with GitHub Actions Inactive
@Ashish8689
Copy link
Contributor Author

@chirag-madlani updated the PR as per comments!

@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 08:41 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 08:41 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 08:41 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 4, 2023 08:41 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
4.4% 4.4% Duplication

@chirag-madlani chirag-madlani merged commit fe7f282 into main Sep 4, 2023
@chirag-madlani chirag-madlani deleted the feat-stored-procedure branch September 4, 2023 11:58
This was referenced Sep 4, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-madlani chirag-madlani chirag-madlani approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

Assignees

@Ashish8689 Ashish8689

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow stored procedures, user defined functions, user defined table types as table types
2 participants
@Ashish8689 @chirag-madlani