Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): supported lineage tab in stored procedure #13060

Merged
merged 6 commits into from
Sep 2, 2023

Conversation

Ashish8689
Copy link
Contributor

Describe your changes:

Fixes #12167

  • supported lineage tab in stored procedure
image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 1, 2023
@Ashish8689 Ashish8689 self-assigned this Sep 1, 2023
@Ashish8689 Ashish8689 temporarily deployed to test September 1, 2023 12:28 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 1, 2023 12:28 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 1, 2023 12:28 — with GitHub Actions Inactive
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 1, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 49%
49.98% (20277/40573) 28.87% (7131/24704) 31.04% (2324/7487)

@cypress
Copy link

cypress bot commented Sep 1, 2023

3 failed tests on run #28882 ↗︎

3 369 37 0 Flakiness 0

Details:

feat: supported lineage tab in stored procedure
Project: openmetadata Commit: 3049fb50c0
Status: Failed Duration: 36:40 💡
Started: Sep 1, 2023 12:55 PM Ended: Sep 1, 2023 1:32 PM
Failed  AddNewService/postgres.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Postgres Ingestion > Verify if usage is ingested properly Output Screenshots Video
Failed  Pages/Teams.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Teams flow should work properly > Remove added user from created team Output Screenshots Video
Failed  Features/ActivityFeed.spec.js • 1 failed test • Tests with database postgresql

View Output Video

Test Artifacts
Activity feed > Mention should work for the feed reply Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 marked this pull request as ready for review September 2, 2023 10:48
Base automatically changed from feat-stored-procedure-tabs to feat-stored-procedure September 2, 2023 10:50
…ng page (#13063)

* feat: supported custom property tab in stored procedure and setting page

* added extension field
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 merged commit 1934b20 into feat-stored-procedure Sep 2, 2023
@Ashish8689 Ashish8689 temporarily deployed to test September 2, 2023 11:03 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 deleted the feat-stored-procedure-lineage-tab branch September 2, 2023 11:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 2, 2023

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
25.7% 25.7% Duplication

chirag-madlani pushed a commit that referenced this pull request Sep 4, 2023
* feat: supported stored procedure in database

* minor fixes

* fix sonar

* optimize stored procedure code and supported deleted flag for it

* feat(ui): supported code and activity tab in stored procedure (#13054)

* supported code and activity tab in stored procedure

* added support for task functionality

* feat(ui): supported lineage tab in stored procedure (#13060)

* supported code and activity tab in stored procedure

* added support for task functionality

* feat: supported lineage tab in stored procedure

* feat(ui): supported custom property tab in stored procedure and setting page (#13063)

* feat: supported custom property tab in stored procedure and setting page

* added extension field

* chanegs as per comments

* chanegs as per comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants