Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui) : supported storedProcedure and dashboardDataModel search index #13194

Merged
merged 12 commits into from
Sep 19, 2023

Conversation

Ashish8689
Copy link
Contributor

@Ashish8689 Ashish8689 commented Sep 14, 2023

Describe your changes:

Fixes: #12998

  • supported stored procedure and dashboard data model search index.
  • added support for stored procedure and dashboard data model in explore and linage page
  • added support for dashboard data model in linage siderbar
  • supported localization in the lineage panel

Pending on :

aggregations filter :

  • Dashboard Data Model : columns
  • StoredProcedure : Database, schema
image image image image image

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@Ashish8689 Ashish8689 added the UI UI specific issues label Sep 14, 2023
@Ashish8689 Ashish8689 self-assigned this Sep 14, 2023
@Ashish8689 Ashish8689 temporarily deployed to test September 14, 2023 13:12 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 14, 2023 13:12 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 14, 2023 13:12 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 14, 2023 13:12 — with GitHub Actions Inactive
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Sep 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 50%
50.36% (21988/43664) 31.3% (8047/25711) 31.31% (2520/8049)

@cypress
Copy link

cypress bot commented Sep 14, 2023

49 failed tests on run #30149 ↗︎

49 377 38 0 Flakiness 0

Details:

Merge branch 'main' into searh-index-entity
Project: openmetadata Commit: f0cb0b8f02
Status: Failed Duration: 35:55 💡
Started: Sep 19, 2023 1:15 PM Ended: Sep 19, 2023 1:51 PM
Failed  Pages/ServiceVersionPage.spec.js • 2 failed tests • Tests with database mysql

View Output Video

Test Artifacts
Messaging service version page > Messaging service version page should show edited tags and description changes properly Output Screenshots
ML Model service version page > Cleanup for ML Model service version page tests Output Screenshots
Failed  Pages/EntityVersionPages.spec.js • 5 failed tests • Tests with database mysql

View Output Video

Test Artifacts
Pipeline version page should work properly > Prerequisite for Pipeline version page test Output Screenshots
Pipeline version page should work properly > Pipeline version page should show description and tag changes properly Output Screenshots
Pipeline version page should work properly > Pipeline version page should show removed tags changes properly Output Screenshots
Pipeline version page should work properly > Pipeline version page should show owner changes properly Output Screenshots
Pipeline version page should work properly > Pipeline version page should show tier changes properly Output Screenshots
Failed  Features/UpdateDisplayName.spec.js • 1 failed test • Tests with database mysql

View Output Video

Test Artifacts
Cleanup > dashboards Output Screenshots
Failed  Pages/Glossary.spec.js • 2 failed tests • Tests with database mysql

View Output Video

Test Artifacts
Glossary page should work properly > Assets Tab should work properly Output Screenshots
Glossary page should work properly > Remove Glossary term from entity should work properly Output Screenshots
Failed  AddNewService/bigquery.spec.js • 3 failed tests • Tests with database mysql

View Output Video

Test Artifacts
BigQuery Ingestion > add and ingest data Output Screenshots
BigQuery Ingestion > Update table description and verify description after re-run Output Screenshots
BigQuery Ingestion > delete created service Output Screenshots

The first 5 failed specs are shown, see all 19 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 06:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 06:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 06:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 06:10 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 07:28 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 07:28 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 07:32 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 temporarily deployed to test September 15, 2023 07:32 — with GitHub Actions Inactive
@Ashish8689 Ashish8689 marked this pull request as ready for review September 15, 2023 08:01
chirag-madlani
chirag-madlani previously approved these changes Sep 16, 2023
* supported storedProcedure as edge in lineage

* fix unit test
@sonarqubecloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[open-metadata-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
1.2% 1.2% Duplication

@chirag-madlani chirag-madlani merged commit d7c212e into main Sep 19, 2023
15 of 22 checks passed
@chirag-madlani chirag-madlani deleted the searh-index-entity branch September 19, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Stored Procedures as another entity under Database Schema
2 participants