Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #13595 Consolidate changes by a user in a single session to a single change #13617

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Fixes #13595 Consolidate changes by a user in a single session to a single change #13617

merged 2 commits into from
Nov 17, 2023

Conversation

sureshms
Copy link
Contributor

@sureshms sureshms commented Oct 17, 2023 •
edited
Loading

Describe your changes:

Fixes #13595 attempt 2

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@sureshms sureshms requested a review from a team as a code owner October 17, 2023 15:00
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Oct 17, 2023
@sureshms sureshms force-pushed the 13595.2 branch 6 times, most recently from ed6aaca to 4934c73 Compare November 8, 2023 17:21
harshach
harshach previously approved these changes Nov 8, 2023
View reviewed changes
@pmbrull pmbrull requested a review from a team as a code owner November 9, 2023 09:49
@sureshms sureshms force-pushed the 13595.2 branch 3 times, most recently from b07f442 to 1c25f8a Compare November 9, 2023 20:21
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sureshms sureshms force-pushed the 13595.2 branch 3 times, most recently from 9af464b to 05ee9da Compare November 10, 2023 02:18
@pmbrull pmbrull mentioned this pull request Nov 10, 2023
Closed
9 tasks
@harshach
Copy link
Collaborator

harshach commented Nov 10, 2023 •
edited
Loading

Failing tests
image

Passing
image

@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@harshach
Copy link
Collaborator

@sureshms added revert flag to not throw errors during the updateDeleted(), checking on changeDescription is not null is not working, as we never set changedescription to null, if we do set it to null, it causes other issues.
Right now only one test is failing for glossary references, which is to store the entity during the revert after the merge

@sureshms sureshms force-pushed the 13595.2 branch 2 times, most recently from ceed778 to b1f0116 Compare November 14, 2023 00:38
@sureshms sureshms force-pushed the 13595.2 branch 3 times, most recently from 0b40366 to 63988ee Compare November 17, 2023 00:54
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn googleformatter:format@reformat-sources in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

@sonarqubecloud SonarQubeCloud
Copy link

[open-metadata-ingestion] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@sureshms sureshms merged commit 5f34bd0 into main Nov 17, 2023
14 checks passed
@sureshms sureshms deleted the 13595.2 branch November 17, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
backend Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate changes by a user in a single session to a single change
3 participants
@sureshms @harshach @chirag-madlani