Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cypress CI workflows for issue-14324 #14334

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Update Cypress CI workflows for issue-14324 #14334

merged 3 commits into from
Dec 13, 2023

Conversation

preetsshah
Copy link
Contributor

@preetsshah preetsshah commented Dec 11, 2023 •
edited
Loading

Describe your changes:

Fixes issue-#14324

These changes introduces the changes requested in issue #14324. With these changes,

  1. The workflow will be triggered for main branch everyday at 00:30 UTC.
  2. The workflow will not run for draft PRs.
  3. The workflow will run only if one of the labels contains 'e2e' in its name.
  4. The workflow will run on 4 machines parallelly.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@preetsshah preetsshah marked this pull request as ready for review December 11, 2023 14:05
@akash-jain-10 akash-jain-10 added the safe to test Add this label to run secure Github workflows on PRs label Dec 12, 2023
akash-jain-10
akash-jain-10 previously approved these changes Dec 12, 2023
View reviewed changes
chirag-madlani
chirag-madlani previously approved these changes Dec 13, 2023
View reviewed changes
@chirag-madlani chirag-madlani merged commit 89a861e into open-metadata:main Dec 13, 2023
12 checks passed
@preetsshah preetsshah mentioned this pull request Dec 13, 2023
Merged
9 tasks
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@preetsshah
Update Cypress CI workflows for issue-14324 (open-metadata#14334)
c62d620 
* Update Cypress CI workflows for issue-14324

* Update Cypress CI workflows to introduce parallel execution

* Update cypress skip CI workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@chirag-madlani chirag-madlani chirag-madlani left review comments

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees

@preetsshah preetsshah

Labels
devops safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI - Cypress run
3 participants
@preetsshah @chirag-madlani @akash-jain-10