Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cypress CI strategy #14372

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Update Cypress CI strategy #14372

merged 1 commit into from
Dec 13, 2023

Conversation

preetsshah
Copy link
Contributor

Describe your changes:

PR - #14334 was missing job strategy fail-fast configuration. Added it in both the Cypress CI.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

akash-jain-10
akash-jain-10 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@akash-jain-10 akash-jain-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@akash-jain-10 akash-jain-10 merged commit 4e5fed7 into open-metadata:main Dec 13, 2023
MrVinegar pushed a commit to MrVinegar/OpenMetadata that referenced this pull request Dec 15, 2023
@preetsshah
Update Cypress CI strategy (open-metadata#14372)
8288df4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-jain-10 akash-jain-10 akash-jain-10 approved these changes

@harshach harshach Awaiting requested review from harshach harshach is a code owner

Assignees
No one assigned
Labels
devops
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@preetsshah @akash-jain-10