-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #14413: Add SAS connector #14415
Conversation
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
2 similar comments
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
hi @MrVinegar, thanks for taking the time to prepare this. I think this is almost done, but might need a bit of work. I believe you might be mixing topics between a supported connector and a custom connector. Custom connectors are there as generic entrypoints for anyone to develop their own logic specific to their organization. If SAS is a generic solution, it might be good to have it as an official supported connector. Here #14087 you can find a similar PR for Apache Doris. Note how the JSON Schemas are defining the exact source connection, instead of relying on a generic "CustomDatabase" This might also be helpful Thanks |
The Python checkstyle failed. Please run You can install the pre-commit hooks with |
@MrVinegar did you get a chance to look at @pmbrull comments above. Let us know if you have any questions. We would love to get this merged in once you address the comments |
Quality Gate passed for 'open-metadata-ui'Kudos, no new issues were introduced! 0 New issues |
Quality Gate failed for 'open-metadata-ingestion'Failed conditions 0.0% Coverage on New Code (required ≥ 20%) |
Thanks @MrVinegar we merged in the connector. |
Thanks so much for everyone's help along the way! Will push out tests and any other modifications to the docs. |
Describe your changes:
Fixes <#14413>
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>
or decision-making process is reflected in the issue.