Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #14413: Add SAS connector #14415

Merged
merged 18 commits into from
Jan 11, 2024
Merged

Conversation

MrVinegar
Copy link
Contributor

@MrVinegar MrVinegar commented Dec 15, 2023

Describe your changes:

Fixes <#14413>

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • The issue properly describes why the new feature is needed, what's the goal, and how we are building it. Any discussion
    or decision-making process is reflected in the issue.
  • I have updated the documentation.
  • I have added tests around the new logic.

@github-actions github-actions bot added documentation Improvements or additions to documentation UI UI specific issues Ingestion backend labels Dec 15, 2023
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

2 similar comments
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the Ready for testing Tickets that are fixed and ready for testing before closing them label Dec 18, 2023
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@pmbrull
Copy link
Collaborator

pmbrull commented Dec 18, 2023

hi @MrVinegar, thanks for taking the time to prepare this.

I think this is almost done, but might need a bit of work. I believe you might be mixing topics between a supported connector and a custom connector.

Custom connectors are there as generic entrypoints for anyone to develop their own logic specific to their organization. If SAS is a generic solution, it might be good to have it as an official supported connector. Here #14087 you can find a similar PR for Apache Doris. Note how the JSON Schemas are defining the exact source connection, instead of relying on a generic "CustomDatabase"

This might also be helpful

Thanks

harshach
harshach previously approved these changes Dec 18, 2023
@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Dec 18, 2023
Copy link
Contributor

The Python checkstyle failed.

Please run make py_format and py_format_check in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Python code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

Copy link
Contributor

github-actions bot commented Dec 18, 2023

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
52.51% (26618/50690) 34.54% (10446/30243) 33.5% (3100/9253)

chirag-madlani
chirag-madlani previously approved these changes Dec 26, 2023
@harshach
Copy link
Collaborator

@MrVinegar did you get a chance to look at @pmbrull comments above. Let us know if you have any questions. We would love to get this merged in once you address the comments

Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Failed Quality Gate failed for 'open-metadata-ingestion'

Failed conditions

0.0% Coverage on New Code (required ≥ 20%)

See analysis details on SonarCloud

@harshach harshach merged commit 241f3c6 into open-metadata:main Jan 11, 2024
32 of 33 checks passed
@harshach
Copy link
Collaborator

Thanks @MrVinegar we merged in the connector.
If you haven't already added docs, please add them in another PR.

@MrVinegar
Copy link
Contributor Author

@MrVinegar did you get a chance to look at @pmbrull comments above. Let us know if you have any questions. We would love to get this merged in once you address the comments

Thanks so much for everyone's help along the way! Will push out tests and any other modifications to the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend devops documentation Improvements or additions to documentation Ingestion Ready for testing Tickets that are fixed and ready for testing before closing them safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants