Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR - update docs & added unit test for SAS Connector #14743

Merged
merged 1 commit into from
Jan 23, 2024
Merged

MINOR - update docs & added unit test for SAS Connector #14743

merged 1 commit into from
Jan 23, 2024

Conversation

MrVinegar
Copy link
Contributor

@MrVinegar MrVinegar commented Jan 16, 2024 •
edited
Loading

Describe your changes:

Small update on the developers documentation to add to 1.3.x information and added unit test. Pt.2 for this previous PR

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@MrVinegar MrVinegar requested a review from a team as a code owner January 16, 2024 22:10
@github-actions github-actions bot added documentation Improvements or additions to documentation Ingestion labels Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Jan 22, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

The SonarCloud Quality Gate passed, but some issues were introduced.

4 New issues
0 Security Hotspots
57.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@harshach harshach merged commit 9f5a70b into open-metadata:main Jan 23, 2024
41 of 47 checks passed
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@MrVinegar @Abhishek332
MINOR - update docs & added unit test for SAS Connector (open-metadat…
26f7542 
…a#14743)

Co-authored-by: Shiyang Xiao <Shiyang.Xiao@sas.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshach harshach harshach approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation Ingestion safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrVinegar @harshach