Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: update git-blmae-ignore-revs, and uncomment ClassificationReso… #14431

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Minor: update git-blmae-ignore-revs, and uncomment ClassificationReso… #14431

merged 1 commit into from
Dec 19, 2023

Conversation

harshach
Copy link
Collaborator

…urceTest tests code

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@harshach harshach requested a review from a team as a code owner December 19, 2023 01:10
@github-actions github-actions bot added backend safe to test Add this label to run secure Github workflows on PRs labels Dec 19, 2023
@github-actions GitHub Actions
Copy link
Contributor

The Java checkstyle failed.

Please run mvn spotless:apply in the root of your repository and commit the changes to this PR.
You can also use pre-commit to automate the Java code formatting.

You can install the pre-commit hooks with make install_test precommit_install.

sureshms
sureshms previously approved these changes Dec 19, 2023
View reviewed changes
@harshach harshach force-pushed the revert_classification_tests branch from 2a75c8d to a22f2b0 Compare December 19, 2023 01:23
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@harshach harshach merged commit 123ed59 into main Dec 19, 2023
21 checks passed
@harshach harshach deleted the revert_classification_tests branch December 19, 2023 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sureshms sureshms sureshms left review comments

Assignees
No one assigned
Labels
backend safe to test Add this label to run secure Github workflows on PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshach @sureshms