Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat #10757: Data observability UI changes #14749

Merged
merged 36 commits into from
Jan 19, 2024
Merged

Feat #10757: Data observability UI changes #14749

merged 36 commits into from
Jan 19, 2024

Conversation

aniketkatkar97
Copy link
Member

Describe your changes:

Fixes

I worked on ... because ...

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

mohityadav766 and others added 27 commits January 10, 2024 23:19
@mohityadav766
Centralize EventType
e6ed381
@mohityadav766
Format better for readability
31491e4
@mohityadav766
Add Handling for Thread as Change Event
fabfdd4
@mohityadav766
Merge branch 'main' into addNotifications
9f801e5
@mohityadav766
Centralize logic for Entity Message Creation
38e0809
@mohityadav766
Merge remote-tracking branch 'origin/addNotifications' into addNotifi…
b3d0ad3 
…cations
@mohityadav766
Merge branch 'main' into addNotifications
5588f9a
@mohityadav766
Merge branch 'main' into addNotifications
a9732b2
@mohityadav766
Add Thread Parent Message in Conversation
07a2d9b
@mohityadav766
Add Task and Announcement
c19bc63
@mohityadav766
Merge branch 'main' into addNotifications
ae4555b
@mohityadav766
Support for multiple destinations
40eb189
@mohityadav766
Merge branch 'main' into addNotifications
d706814
@mohityadav766
Delete existing alerts for schema changes
ea50d1d
@mohityadav766
Delete all tables data for event subscription
e7fbc1b
@mohityadav766
Centralize logic for Notifications and Observability
f5beb37
@mohityadav766
Change Field Name and Remove redundant code
a9e398f
@mohityadav766
Test Fixes
26bdc92
@mohityadav766
Add more fields
821a0e3
@mohityadav766
Add Optional
eb23e80
@mohityadav766
Merge branch 'main' into addNotifications
cc76898
@mohityadav766
Logical Test Case Addition Chnage Event
327b3d8
@mohityadav766
Add Filter By Owner
b22de8a
@mohityadav766
Fix Email Entity Url
55fc0c1
@mohityadav766
Merge branch 'main' into addNotifications
bc92de5
@aniketkatkar97
added data observability settings page
83f6e7c
@aniketkatkar97
localization changes for other languages
345e351
@aniketkatkar97 aniketkatkar97 self-assigned this Jan 17, 2024
@github-actions github-actions bot added UI UI specific issues backend labels Jan 17, 2024
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 17, 2024
@chirag-madlani chirag-madlani changed the base branch from main to addNotifications January 17, 2024 06:09
@github-actions github-actions bot removed the backend label Jan 17, 2024
Base automatically changed from addNotifications to main January 18, 2024 07:16
@github-actions github-actions bot removed the backend label Jan 18, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@chirag-madlani chirag-madlani marked this pull request as ready for review January 19, 2024 06:50
Sachin-chaurasiya
Sachin-chaurasiya reviewed Jan 19, 2024
View reviewed changes
Copy link
Member

@Sachin-chaurasiya Sachin-chaurasiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, we can take care of these comments in the next patch, moreover please take care of the fqn encoding/decoding part, thanks.

openmetadata-ui/src/main/resources/ui/src/pages/AddAlertPage/AddAlertPage.tsx Show resolved Hide resolved
...src/pages/AddObservabilityPage/ObservabilityFormFiltersItem/ObservabilityFormFiltersItem.tsx Show resolved Hide resolved
openmetadata-ui/src/main/resources/ui/src/rest/observabilityAPI.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 52%
 52.58% (26865/51093) 35.05% (10708/30551) 33.48% (3133/9357)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

The SonarCloud Quality Gate passed, but some issues were introduced.

5 New issues
0 Security Hotspots
0.0% Coverage on New Code
31.4% Duplication on New Code

See analysis details on SonarCloud

@chirag-madlani chirag-madlani merged commit f3f73a3 into main Jan 19, 2024
13 of 16 checks passed
@chirag-madlani chirag-madlani deleted the alerts-refactoring-ui branch January 19, 2024 09:00
Abhishek332 pushed a commit to Abhishek332/OpenMetadata that referenced this pull request Jan 25, 2024
@aniketkatkar97 @mohityadav766
@chirag-madlani @Abhishek332
Feat open-metadata#10757: Data observability UI changes (open-metadat…
ecf60e8 
…a#14749)

* Centralize EventType

* Format better for readability

* Add Handling for Thread as Change Event

* Centralize logic for Entity Message Creation

* Add Thread Parent Message in Conversation

* Add Task and Announcement

* Support for multiple destinations

* Delete existing alerts for schema changes

* Delete all tables data for event subscription

* Centralize logic for Notifications and Observability

* Change Field Name and Remove redundant code

* Test Fixes

* Add more fields

* Add Optional

* Logical Test Case Addition Chnage Event

* Add Filter By Owner

* Fix Email Entity Url

* added data observability settings page

* localization changes for other languages

* Handler closure and cleanup

* complete create observibility flow

* fix searchIndex method error

---------

Co-authored-by: mohitdeuex <mohit.y@deuexsolutions.com>
Co-authored-by: Mohit Yadav <105265192+mohityadav766@users.noreply.github.com>
Co-authored-by: Chirag Madlani <12962843+chirag-madlani@users.noreply.github.com>
@aniketkatkar97 aniketkatkar97 mentioned this pull request Jan 29, 2024
Merged
5 tasks
This was referenced Jan 30, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sachin-chaurasiya Sachin-chaurasiya Sachin-chaurasiya approved these changes

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

Assignees

@aniketkatkar97 aniketkatkar97

Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aniketkatkar97 @Sachin-chaurasiya @chirag-madlani @mohityadav766