Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Unit tests for observability and notification alert flow components #14908

Merged
merged 16 commits into from
Feb 1, 2024

Conversation

aniketkatkar97
Copy link
Member

Unit tests for #10757
I worked on adding unit tests for newly added components in #14749

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.

@aniketkatkar97 aniketkatkar97 self-assigned this Jan 29, 2024
@aniketkatkar97 aniketkatkar97 added the UI UI specific issues label Jan 29, 2024
@aniketkatkar97 aniketkatkar97 requested a review from a team January 29, 2024 04:28
@github-actions github-actions bot added the safe to test Add this label to run secure Github workflows on PRs label Jan 29, 2024
Copy link
Contributor

github-actions bot commented Jan 29, 2024

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 53%
53.98% (27894/51676) 35.75% (11125/31121) 34.78% (3292/9465)

@Sachin-chaurasiya Sachin-chaurasiya enabled auto-merge (squash) February 1, 2024 18:51
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Sachin-chaurasiya Sachin-chaurasiya merged commit 3d7085e into main Feb 1, 2024
15 checks passed
@Sachin-chaurasiya Sachin-chaurasiya deleted the alert-unit-tests branch February 1, 2024 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants