Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MINOR: add MongoDB sample data #15237

Merged
merged 14 commits into from
Feb 22, 2024
Merged

MINOR: add MongoDB sample data #15237

merged 14 commits into from
Feb 22, 2024

Conversation

sushi30
Copy link
Contributor

@sushi30 sushi30 commented Feb 19, 2024 •
edited
Loading

Builds on:

Describe your changes:

Added sample data to MongoDB process:

image

Details

  1. Changed method names on NoSQLAdaptor to be more inline with entities in NoSQL dbs and avoind confusion with the ProfilerInterface.
  2. Use SetUpClass to store all test states across test cases... Shaves off 5-10 seconds.
  3. Added the NoSQLSampler.
  4. Since NoSQL behaves differently from SQL engines.

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title is Fixes <issue-number>: <short explanation>
  • I have commented on my code, particularly in hard-to-understand areas.
  • For JSON Schema changes: I updated the migration scripts or explained why it is not needed.
  • I have added tests around the new logic.
  • For connector/ingestion changes: I updated the documentation.

sushi30 added 12 commits February 15, 2024 11:37
@sushi30
feat(nosql-profiler): row count
ee63fc9 
1. Implemented the NoSQLProfilerInterface as an entrypoint for the nosql profiler.
2. Added the NoSQLMetric as an abstract class.
3. Implemented the interface for the MongoDB database source.
4. Implemented an e2e test using testcontainers.
@sushi30
added profiler support for mongodb connection
5982786
@sushi30
doc
9357355
@sushi30
Merge remote-tracking branch 'origin/main' into nosql-row-count
91e103e
@sushi30
use int_admin_ometa in test setup
74c2abd
@sushi30
- fixed linting issue in gx
ba8e872 
- removed unused inheritance
@sushi30
moved the nosql function into the metric class
d261553
@sushi30
formatting
ffca0e6
@sushi30
validate_compose: raise exception for bad status code.
215ac9c
@sushi30
fixed import
1733b9a
@sushi30
format
e4d794d
@sushi30
feat(nosql-profiler): added sample data
3677d57 
1. Implemented the NoSQL sampler.
2. Some naming changes to the NoSQL adaptor to avoid fixing names with the profiler interface.
3. Tests.
@github-actions github-actions bot added UI UI specific issues Ingestion backend devops safe to test Add this label to run secure Github workflows on PRs labels Feb 19, 2024
@sushi30 sushi30 changed the base branch from main to nosql-row-count February 19, 2024 09:57
@github-actions GitHub Actions
Copy link
Contributor

Jest test Coverage

UI tests summary

Lines Statements Branches Functions
Coverage: 61%
 61.6% (31443/51047) 40.59% (12542/30898) 40.91% (3862/9441)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ui'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sushi30 sushi30 mentioned this pull request Feb 19, 2024
Merged
5 tasks
This was referenced Feb 19, 2024
Merged
Merged
@sushi30 sushi30 mentioned this pull request Feb 20, 2024
Closed
TeddyCr
TeddyCr previously approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@TeddyCr TeddyCr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 🚀

Base automatically changed from nosql-row-count to main February 22, 2024 10:46
@sushi30 sushi30 dismissed TeddyCr’s stale review February 22, 2024 10:46

The base branch was changed.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'open-metadata-ingestion'

Issues
2 New issues

Measures
0 Security Hotspots
93.2% Coverage on New Code
0.3% Duplication on New Code

See analysis details on SonarCloud

@sushi30 sushi30 requested a review from TeddyCr February 22, 2024 13:47
@sushi30 sushi30 merged commit ff2ecc5 into main Feb 22, 2024
11 checks passed
@sushi30 sushi30 deleted the nosql-profiler-sample-data branch February 22, 2024 15:31
TeddyCr added a commit to TeddyCr/OpenMetadata that referenced this pull request Feb 28, 2024
@TeddyCr
Revert "MINOR: add MongoDB sample data (open-metadata#15237)"
8ac2cef 
This reverts commit ff2ecc5.
TeddyCr added a commit that referenced this pull request Feb 28, 2024
@TeddyCr
1.3.1 reverts (#15386)
7456915 
* Revert "add migration for MongoDB supportsProfiler = true (#15254)"

This reverts commit ec3eb29.

* Revert "MINOR: Mongodb column profile (#15252)"

This reverts commit 50b2709.

* Revert "MINOR: modified nosql factory to not use pymongo (#15316)"

This reverts commit bdf2745.

* Revert "MINOR: add MongoDB sample data (#15237)"

This reverts commit ff2ecc5.

* Revert "MINOR: add test for sqla compiler (#15275)"

This reverts commit 4967e09.

* Revert "Fixes #10013: Implement first stage of NoSQL profiler (#15189)"

This reverts commit 18c22c4.

* chore: added tests back after revert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TeddyCr TeddyCr TeddyCr approved these changes

@akash-jain-10 akash-jain-10 Awaiting requested review from akash-jain-10

@harshach harshach Awaiting requested review from harshach

@karanh37 karanh37 Awaiting requested review from karanh37

@chirag-madlani chirag-madlani Awaiting requested review from chirag-madlani

@Sachin-chaurasiya Sachin-chaurasiya Awaiting requested review from Sachin-chaurasiya

Assignees
No one assigned
Labels
backend devops Ingestion safe to test Add this label to run secure Github workflows on PRs UI UI specific issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sushi30 @TeddyCr