add migration for MongoDB supportsProfiler = true #15254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Ingestion
safe to test
harshach
approved these changes
Feb 19, 2024
|
@sushi30 we are not using the flyway for new migrations. Please use native migrations to add this change |
harshach
requested changes
Feb 19, 2024
|
@harshach done |
pmbrull
reviewed
Feb 20, 2024
| @@ -0,0 +1,4 @@ | |||
| -- Add the supportsProfiler field to the MongoDB connection configuration | |||
| UPDATE dbservice_entity | |||
| SET json = JSON_INSERT(json, '$.connection.config.supportsProfiler', TRUE) | |||
There was a problem hiding this comment.
should this be 1.3.1 though? If we'll deploy all these NoSQL thingies by 1.3.2 - 1.4.0, might be better to leave the 1.3.1 clean
harshach
previously approved these changes
Feb 20, 2024
# Conflicts: # ingestion/src/metadata/profiler/adaptors/mongodb.py # ingestion/src/metadata/profiler/adaptors/nosql_adaptor.py # ingestion/src/metadata/profiler/interface/nosql/profiler_interface.py # ingestion/tests/integration/profiler/test_nosql_profiler.py
|
resolved conflicts |
ulixius9
approved these changes
Feb 27, 2024
pmbrull
added a commit
to pmbrull/OpenMetadata
that referenced
this pull request
Feb 28, 2024
…ata#15254)" This reverts commit ec3eb29.
TeddyCr
added a commit
to TeddyCr/OpenMetadata
that referenced
this pull request
Feb 28, 2024
…ata#15254)" This reverts commit ec3eb29.
TeddyCr
added a commit
that referenced
this pull request
Feb 28, 2024
* Revert "add migration for MongoDB supportsProfiler = true (#15254)" This reverts commit ec3eb29. * Revert "MINOR: Mongodb column profile (#15252)" This reverts commit 50b2709. * Revert "MINOR: modified nosql factory to not use pymongo (#15316)" This reverts commit bdf2745. * Revert "MINOR: add MongoDB sample data (#15237)" This reverts commit ff2ecc5. * Revert "MINOR: add test for sqla compiler (#15275)" This reverts commit 4967e09. * Revert "Fixes #10013: Implement first stage of NoSQL profiler (#15189)" This reverts commit 18c22c4. * chore: added tests back after revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Add migration for MongoDB profiler support.
Depends on:
Type of change:
Checklist:
Fixes <issue-number>: <short explanation>